GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-99113: restore behaviour of PyThreadState_Swap by asottile · Pull Request #123079 · python/cpython

Conversation

@asottile

@asottile asottile commented Aug 16, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

in #104208 it was inadvertently (?) changed to acquire the GIL

for more context and a bisection see unbit/uwsgi#2659

  • Issue: Implement PEP 684: A Per-Interpreter GIL #99113

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@asottile
restore behaviour of PyThreadState_Swap
01f131e 
in python#104208 it was inadvertently (?) changed to acquire the GIL
@bedevere-app bedevere-app Bot mentioned this pull request Aug 16, 2024
Implement PEP 684: A Per-Interpreter GIL #99113
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Aug 16, 2024
This was referenced Aug 16, 2024
gh-99113: Make Sure the GIL is Acquired at the Right Places #104208
Merged
pyuwsgi + enable-threads + python3.12: workers do not recover after a reload unbit/uwsgi#2659
Closed
@asottile

asottile commented Aug 16, 2024

Copy link
Copy Markdown
Contributor Author

hmmm given the test failures maybe this isn't the right approach. going to see if there's some UB in uwsgi first before approaching this more
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asottile asottile closed this Aug 16, 2024
@asottile
asottile deleted the fix-threadstate-swap-regression branch August 19, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@asottile
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.