GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-99108: Fix Setup in addition to Setup.stdlib.in by msprotz · Pull Request #123146 · python/cpython

Conversation

@msprotz

@msprotz msprotz commented Aug 19, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

See #119316

I don't think this warrants a NEWS entry

  • Issue: Replace built-in hashlib with verified implementations from HACL* #99108

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@msprotz
Fix Setup in addition to Setup.stdlib.in
c2cc6f0
@msprotz
msprotz requested a review from erlend-aasland as a code owner August 19, 2024 14:59
@bedevere-app bedevere-app Bot mentioned this pull request Aug 19, 2024
Replace built-in hashlib with verified implementations from HACL* #99108
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Aug 19, 2024
@msprotz msprotz mentioned this pull request Aug 19, 2024
gh-99108: Add HACL* Blake2 implementation to hashlib #119316
Merged
@msprotz

msprotz commented Aug 19, 2024

Copy link
Copy Markdown
Contributor Author

Just to be clear, my local build does not seem to pick up Setup and instead uses Setup.stdlin.in, so @asottile could you please confirm that this is good? Thank you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asottile

asottile commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

this looks correct to me -- or at least it matches the other ones. I could run a test build but that's going to take more time than I have free today :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Aug 23, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 23, 2024
@erlend-aasland

erlend-aasland commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

this looks correct to me -- or at least it matches the other ones. I could run a test build but that's going to take more time than I have free today :(

There is no way to get Modules/Setup "correct"; it never will be and it never has been. It should be removed, and the (few, hopefully) projects depending on it should find other ways to get what they need.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland added the skip news label Aug 23, 2024
@erlend-aasland
erlend-aasland merged commit a64aa47 into python:main Aug 23, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@msprotz @asottile @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.