GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-122981: Fix inspect.getsource() for generated classes with Python base classes (GH-123001) by miss-islington · Pull Request #123182 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 20, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Look up firstlineno only in the class' dict, without searching in
base classes.
(cherry picked from commit f88c14d)

Co-authored-by: Serhiy Storchaka [email protected]

  • Issue: 3.13 Regression: inspect.getsource() returns incorrect source code #122981

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka @miss-islington
pythongh-122981: Fix inspect.getsource() for generated classes with P…
f19222e
…ython base classes (pythonGH-123001)

Look up __firstlineno__ only in the class' dict, without searching in
base classes.
(cherry picked from commit f88c14d)

Co-authored-by: Serhiy Storchaka <[email protected]>
This was referenced Aug 20, 2024
gh-122981: Fix inspect.getsource() for generated classes with Python base classes #123001
Merged
3.13 Regression: inspect.getsource() returns incorrect source code #122981
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Aug 20, 2024
@Yhg1s
Yhg1s merged commit 2b4c31d into python:3.13 Sep 2, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 2, 2024
@miss-islington
miss-islington deleted the backport-f88c14d-3.13 branch January 2, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @Yhg1s @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.