GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-82378 fix sys.tracebacklimit in pyrepl (GH-123062) by cfbolz · Pull Request #123252 · python/cpython

Conversation

@cfbolz

@cfbolz cfbolz commented Aug 23, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Finally backport gh-123062: Make sure that pyrepl uses the same logic for sys.tracebacklimit as both the basic repl and the standard sys.excepthook
(cherry picked from commit 63603bc)

  • Issue: Meaning of tracebacklimit differs between sys.tracebacklimit and traceback module #82378

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@cfbolz
[3.13] pythongh-82378 fix sys.tracebacklimit in pyrepl, approach 2 (p…
b847597
…ythonGH-123062)

Make sure that pyrepl uses the same logic for sys.tracebacklimit as both
the basic repl and the standard sys.excepthook
(cherry picked from commit 63603bc)

Co-authored-by: CF Bolz-Tereick <[email protected]>
This was referenced Aug 23, 2024
gh-82378 fix sys.tracebacklimit in pyrepl #123062
Merged
Meaning of tracebacklimit differs between sys.tracebacklimit and traceback module #82378
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 23, 2024
@cfbolz

cfbolz commented Aug 23, 2024

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka would you maybe have time to look at this? I think it's the last remaining "in the wrong order" pyrepl backport, hopefully afterwards they will happen without conflicts again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka
serhiy-storchaka approved these changes Aug 23, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 23, 2024
@pablogsal
pablogsal merged commit 0955db1 into python:3.13 Aug 23, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 23, 2024
@pablogsal pablogsal changed the title [3.13] gh-82378 fix sys.tracebacklimit in pyrepl, approach 2 (GH-123062) [3.13] gh-82378 fix sys.tracebacklimit in pyrepl (GH-123062) Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@cfbolz @serhiy-storchaka @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.