GeezerVison is showing github.com — GH-73991: Make `pathlib.Path.delete()` private. by barneygale · Pull Request #123315 · python/cpython
Conversation
barneygale
commented
Aug 25, 2024
•
edited by github-actions
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Per feedback from Paul Moore on GH-123158, it's better to defer making Path.delete() public than ship it with under-designed error handling capabilities.
We leave a remnant _delete() method, which is used by move(). Any functionality not needed by move() is deleted.
📚 Documentation preview 📚: https://cpython-previews--123315.org.readthedocs.build/
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Per feedback from Paul Moore on pythonGH-123158, it's better to defer making
`Path.delete()` public than ship it with under-designed error handling
capabilities.
We leave a remnant `_delete()` method, which is used by `move()`. Any
functionality not needed by `move()` is deleted.
barneygale
commented
Aug 25, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
The primary reason why I don't want to expose on_error is that it makes it harder to write a compatible implementation of delete() in a future user subclass of PathBase. Any algorithmic deviation would result in an observable change in how/when the error handler is called, even if the end result is the same. If we keep a delete() method with an on_error handler, I'd feel I'd boxed myself into a corner.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Any algorithmic deviation would result in an observable change in how/when the error handler is called, even if the end result is the same.
Ah. I hadn't appreciated that was your concern. I think it's a valid reason to be cautious, but I suspect it's something that we won't be able to do anything about. In the medium term, we may be best simply documenting our way out of the issue - stating in the API docs that users cannot rely on when, if or how on_error will be called, just that if it's called, an error will have occurred, and if the operation completes without on_error being called, then no errors occurred that the implementation couldn't automatically handle. Long term, maybe we'll be able to give tighter API guarantees, but let's not hold up implementing something useful in order to wait for that. And yes, some people will rely on implementation details and be caught out, but we can't do anything about that beyond say "we told you so"...
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
pfmoore
pfmoore approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|