GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] gh-123270: Replaced SanitizedNames with a more surgical fix. (GH-123354) by jaraco · Pull Request #123432 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented Aug 28, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Applies changes from zipp 3.20.1 and jaraco/zipp#124 (cherry picked from commit 2231286) (cherry picked from commit 17b77bb)

Supersedes #123161.

  • Issue: zipfile.Path regression #123270

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaraco
[3.9] [3.11] pythongh-123270: Replaced SanitizedNames with a more sur…
66d3383 
…gical fix. (pythonGH-123354)

Applies changes from zipp 3.20.1 and jaraco/zippGH-124
(cherry picked from commit 2231286)
(cherry picked from commit 17b77bb)

Co-authored-by: Jason R. Coombs <[email protected]>
This was referenced Aug 28, 2024
gh-123270: Replaced SanitizedNames with a more surgical fix. #123354
Merged
zipfile.Path regression #123270
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 28, 2024
@jaraco

jaraco commented Aug 28, 2024

Copy link
Copy Markdown
Member Author

Although the build fails, we can be confident that the functionality is good, because these changes were adopted by zipp 3.20.1 and tested against Python 3.9 on macOS.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco

jaraco commented Sep 2, 2024

Copy link
Copy Markdown
Member Author

I don't understand why the tests are passing on Windows when two of the the 3.10 tests in #123426 were failing on Windows.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco

jaraco commented Sep 2, 2024

Copy link
Copy Markdown
Member Author

Aha! It's because in Python 3.9, zipfile.Path.name still uses posixpath.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco
Restore the slash-prefixed paths in the malformed_paths test.
43c2b07
@ambv
ambv merged commit 9620552 into python:3.9 Sep 4, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jaraco @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.