GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-121285: Remove backtracking when parsing tarfile headers (GH-121286) by miss-islington · Pull Request #123542 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 31, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Remove backtracking when parsing tarfile headers
  • Rewrite PAX header parsing to be stricter
  • Optimize parsing of GNU extended sparse headers v0.0

(cherry picked from commit 34ddb64)

Co-authored-by: Seth Michael Larson [email protected]
Co-authored-by: Kirill Podoprigora [email protected]
Co-authored-by: Gregory P. Smith [email protected]

  • Issue: Remove backtracking from parsing tarfile members and headers #121285

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sethmlarson @Eclips4
@gpshead @miss-islington
pythongh-121285: Remove backtracking when parsing tarfile headers (py…
c47341f 
…thonGH-121286)

* Remove backtracking when parsing tarfile headers
* Rewrite PAX header parsing to be stricter
* Optimize parsing of GNU extended sparse headers v0.0

(cherry picked from commit 34ddb64)

Co-authored-by: Seth Michael Larson <[email protected]>
Co-authored-by: Kirill Podoprigora <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
@miss-islington
miss-islington requested a review from ethanfurman as a code owner August 31, 2024 22:17
@bedevere-app bedevere-app Bot mentioned this pull request Aug 31, 2024
gh-121285: Remove backtracking when parsing tarfile headers #121286
Merged
@bedevere-app bedevere-app Bot added the type-security A security issue label Aug 31, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Aug 31, 2024
Remove backtracking from parsing tarfile members and headers #121285
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Aug 31, 2024
gpshead
gpshead approved these changes Aug 31, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 31, 2024
@gpshead gpshead assigned Yhg1s Aug 31, 2024
@Yhg1s
Yhg1s merged commit ed3a49e into python:3.13 Sep 2, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 2, 2024
pullenmil
pullenmil reviewed Oct 8, 2024
View reviewed changes

@pullenmil pullenmil left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will compress your bulk put it in a hidden lib file and wont have to ask to keep. will keep out syntax error

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/tarfile.py
@@ -846,6 +846,9 @@ def data_filter(member, dest_path):
# Sentinel for replace() defaults, meaning "don't change the attribute"
_KEEP = object()

@pullenmil pullenmil Oct 8, 2024

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_bulk=object()

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@miss-islington
miss-islington deleted the backport-34ddb64-3.13 branch January 2, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner
+1 more reviewer
@pullenmil pullenmil pullenmil left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @gpshead @pullenmil @Yhg1s @sethmlarson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.