GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-121285: Remove backtracking when parsing tarfile headers (GH-121286) by sethmlarson · Pull Request #123639 · python/cpython

Conversation

@sethmlarson

@sethmlarson sethmlarson commented Sep 3, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Remove backtracking when parsing tarfile headers
  • Rewrite PAX header parsing to be stricter
  • Optimize parsing of GNU extended sparse headers v0.0

(cherry picked from commit 34ddb64)

  • Issue: Remove backtracking from parsing tarfile members and headers #121285

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sethmlarson @Eclips4 @gpshead
[3.11] pythongh-121285: Remove backtracking when parsing tarfile head…
b743113 
…ers (pythonGH-121286)

* Remove backtracking when parsing tarfile headers
* Rewrite PAX header parsing to be stricter
* Optimize parsing of GNU extended sparse headers v0.0

(cherry picked from commit 34ddb64)

Co-authored-by: Seth Michael Larson <[email protected]>
Co-authored-by: Kirill Podoprigora <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
@sethmlarson sethmlarson added type-security A security issue release-blocker labels Sep 3, 2024
@sethmlarson
sethmlarson requested a review from pablogsal September 3, 2024 14:53
@sethmlarson
sethmlarson requested a review from ethanfurman as a code owner September 3, 2024 14:53
@bedevere-app bedevere-app Bot added the awaiting review label Sep 3, 2024
This was referenced Sep 3, 2024
gh-121285: Remove backtracking when parsing tarfile headers #121286
Merged
Remove backtracking from parsing tarfile members and headers #121285
Closed
@sethmlarson sethmlarson changed the title [3.11] gh-121285: Remove backtracking when parsing tarfile headers (G… [3.11] gh-121285: Remove backtracking when parsing tarfile headers (GH-121286) Sep 3, 2024
pablogsal
pablogsal approved these changes Sep 3, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 3, 2024
@pablogsal
pablogsal enabled auto-merge (squash) September 3, 2024 14:59
@pablogsal
pablogsal merged commit d449caf into python:3.11 Sep 3, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

release-blocker type-security A security issue

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sethmlarson @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.