GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-123599: Reject non-local authority in `pathlib.Path.from_uri()` on POSIX by barneygale · Pull Request #123650 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Sep 3, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Raise ValueError in pathlib.Path.from_uri() if the given file: URI specifies a non-empty, non-localhost authority, and we're running on a platform without support for UNC paths.

  • Issue: Path.from_uri() doesn't work if the URI contains host component #123599

📚 Documentation preview 📚: https://cpython-previews--123650.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
pythonGH-123599: Reject non-local authority in `pathlib.Path.from_uri…
0cee0c4 
…()` on POSIX

Raise `ValueError` in `pathlib.Path.from_uri()` if the given `file:` URI
specifies a non-empty, non-`localhost` authority, and we're running on a
platform without support for UNC paths.
@barneygale barneygale added topic-pathlib needs backport to 3.13 only security fixes labels Sep 3, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 3, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 3, 2024
Path.from_uri() doesn't work if the URI contains host component #123599
Closed
barneygale added 4 commits September 3, 2024 23:49
@barneygale
Fix news blurb lint.
b1cea29
@barneygale
Check for other local names/addresses on POSIX.
25b3978
@barneygale
Merge branch 'main' into pythongh-123599-reject-non-local
ac43afd
@barneygale
Fix WASI
38233cd
@barneygale
barneygale requested a review from AA-Turner October 21, 2024 15:15
@barneygale

barneygale commented Oct 23, 2024

Copy link
Copy Markdown
Contributor Author

In fact, I might implement this by making urllib.request.pathname2url() and url2pathname() less awful. Marking as a draft...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
barneygale marked this pull request as draft October 23, 2024 01:54
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 23, 2024
@barneygale

barneygale commented Mar 19, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Closing in favour of #126844
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale barneygale closed this Mar 19, 2025
@barneygale barneygale mentioned this pull request Mar 20, 2025
GH-123599: Deprecate duplicate pathname2url() implementation #127380
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs backport to 3.13 only security fixes topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@barneygale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.