GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-123693: Use platform-agnostic semantics when processing zipfile.Path.name. by jaraco · Pull Request #123694 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented Sep 4, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Depends on, merge after GH-123426.

  • [3.10] zipfile.Path.name uses inappropriate Windows semantics #123693: When computing the zipfile.Path.name, use PurePosixPath for platform-agnostic behavior.

Closes #123693.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jaraco added 7 commits August 28, 2024 09:26
@jaraco
[3.10] [3.11] pythongh-123270: Replaced SanitizedNames with a more su…
c94488e 
…rgical fix. (pythonGH-123354)

Applies changes from zipp 3.20.1 and jaraco/zippGH-124
(cherry picked from commit 2231286)
(cherry picked from commit 17b77bb)

Co-authored-by: Jason R. Coombs <[email protected]>
@jaraco
Add some context to the assertion for troubleshooting.
87ac08d
@jaraco
Remove tests not relevant to the backported security fix.
d1eca1e 
Ref python#123426 (comment)
@jaraco
Restore the slash-prefixed paths in the malformed_paths test.
d5c243c
@jaraco
Revert "Remove tests not relevant to the backported security fix."
ee0d35f 
This reverts commit d1eca1e.
@jaraco
Skip failing tests, known to fail, referencing tracking bug.
45a7927
@jaraco
[3.10] pythongh-123693: When computing the zipfile.Path.name, use Pur…
7990bf9 
…ePosixPath for platform-agnostic behavior.

Aligns with Python 3.9 and 3.11 behavor and fixes failing tests.
@jaraco

jaraco commented Sep 4, 2024

Copy link
Copy Markdown
Member Author

I chose not to replace the patch with exactly the patch that is found in Python 3.11 and later, because that changed other semantics. I'm expecting this selective change to allow the tests to pass and address the missed expectation.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco jaraco mentioned this pull request Sep 4, 2024
[3.10] gh-123270: Replaced SanitizedNames with a more surgical fix. (GH-123354) #123426
Merged
@jaraco
jaraco marked this pull request as ready for review September 4, 2024 18:18
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 4, 2024
@jaraco

jaraco commented Sep 4, 2024

Copy link
Copy Markdown
Member Author

Until this PR is rebased onto main after merging the dependent PR, here is the diff for this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zooba
zooba approved these changes Sep 4, 2024
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 4, 2024
@jaraco
Remove unused import
9f1dac0
@ambv

ambv commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

You can rebase now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jaraco added 2 commits September 4, 2024 16:44
@jaraco
Merge branch '3.10' into pythongh-123693/platform-agnostic-name
d7d5cad
@jaraco
Remove unused import
0df599f
@jaraco

jaraco commented Sep 4, 2024

Copy link
Copy Markdown
Member Author

I've merged and the diff is now good. The macOS failure is unrelated. I did not rebase, as the squash merge will handle that. Please merge whenever.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit 4633177 into python:3.10 Sep 5, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 5, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 4, 2024
zipfile.Path.name uses inappropriate Windows semantics #123693
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jaraco @ambv @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.