GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-123905: Update TOML description to include version number by paulehoffman · Pull Request #123825 · python/cpython

Conversation

@paulehoffman

@paulehoffman paulehoffman commented Sep 8, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There is some movement, currently blocked, that would update the TOML spec to 1.1.0; this would include breaking changes to what characters are allowed. Thus, it is worthwhile for the library page to be clear which version is implemented here.

📚 Documentation preview 📚: https://cpython-previews--123825.org.readthedocs.build/

  • Issue: Update TOML description to include version number #123905

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@paulehoffman
Update TOML description to include version number
ac9a853 
There is some movement, currently blocked, that would update the TOML spec to 1.1.0; this would include breaking changes to what characters are allowed. Thus, it is worthwhile for the library page to be clear which version is implemented here.
@paulehoffman
paulehoffman requested review from encukou and hauntsaninja as code owners September 8, 2024 00:23
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 8, 2024
@vstinner

vstinner commented Sep 9, 2024

Copy link
Copy Markdown
Member

cc @encukou
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou changed the title Update TOML description to include version number gh-123905: Update TOML description to include version number Sep 10, 2024
@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Sep 10, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 10, 2024
Update TOML description to include version number #123905
Closed
@encukou

encukou commented Sep 10, 2024

Copy link
Copy Markdown
Member

That makes sense, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Sep 10, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Process issues:

  • PRs that need backporting (like most docs ones) need an issue open. We use the issue number to keep related PRs together.
    I've filed an issue for this.
  • PRs should be opened to the main branch, and backported from there
    Retargetting an open PR is messy, so I'll close this PR and open a new one. (edit: it's gh-123905: Update TOML description to include version number #123906)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou closed this Sep 10, 2024
@encukou encukou mentioned this pull request Sep 10, 2024
gh-123905: Update TOML description to include version number #123906
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou Awaiting requested review from encukou encukou is a code owner
@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja hauntsaninja is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@paulehoffman @vstinner @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.