GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116622: Kill Android Signal Catcher thread before running tests by mhsmith · Pull Request #123982 · python/cpython

Conversation

@mhsmith

@mhsmith mhsmith commented Sep 11, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is an alternative attempt to fix the problem described in #123981, by killing the Android Signal Catcher completely. But it ended up being quite large and complex, and depends on several internal details which Android might change in the future.

Also, when I tried to test the "SignalCatcher TID %d still exists" message by commenting out the first tgkill call, I found that about 80% of the time, the 0.1 second delay between installing the signal handler and sending the signal somehow caused the handler to be bypassed, and the signal to kill the process. I have no idea why that would happen, and that makes me feel even less confident about this approach.

As #123981 says, the original problem only occurs in a fairly rare combination of circumstances, has a clearly-identifiable log message, and some easy workarounds, so it isn't worth pursuing this.

  • Issue: Add support for Android as a target platform #116622

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mhsmith
Kill Android Signal Catcher thread before running tests
58173d5
@mhsmith mhsmith added the DO-NOT-MERGE label Sep 11, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 11, 2024
Add support for Android as a target platform #116622
Closed
@mhsmith
mhsmith marked this pull request as ready for review September 11, 2024 22:18
@bedevere-app bedevere-app Bot added the awaiting review label Sep 11, 2024
@mhsmith mhsmith closed this Sep 11, 2024
@mhsmith mhsmith mentioned this pull request Sep 11, 2024
gh-116622: Switch test_stress_delivery_simultaneous from SIGUSR1 to SIGUSR2 #123981
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@mhsmith
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.