GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-124153: Remove `_PyType_GetModuleByDef2` private function by neonene · Pull Request #124262 · python/cpython

Conversation

@neonene

@neonene neonene commented Sep 20, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This function was introduced in #117578, which will no longer be used superseded by #124261.

cc @encukou

  • Issue: Add PyType_GetBaseByToken function with Py_tp_token slot #124153

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@neonene
move get_module_by_def() into PyType_GetModuleByDef()
bb37f41
@neonene
neonene requested a review from markshannon as a code owner September 20, 2024 03:39
@bedevere-app bedevere-app Bot added the awaiting review label Sep 20, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 20, 2024
Add PyType_GetBaseByToken function with Py_tp_token slot #124153
Closed
6 tasks done
@neonene
Update pycore_typeobject.h
58cdbd0
vstinner
vstinner reviewed Sep 20, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must update Modules/_decimal/_decimal.c: see the warnings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner

vstinner commented Sep 20, 2024

Copy link
Copy Markdown
Member

I suggest to mark this PR as a draft and wait until #124261 is merged.
neonene reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@neonene
neonene marked this pull request as draft September 20, 2024 11:29
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 20, 2024
@neonene

This comment was marked as outdated.

Sign in to view
@neonene
insert a space
a43af03
@vstinner vstinner mentioned this pull request Sep 24, 2024
gh-124153: Remove _PyType_GetModuleByDef2 private function #124261
Merged
@neonene

neonene commented Sep 24, 2024

Copy link
Copy Markdown
Contributor Author

Migrated to #124261.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@neonene neonene closed this Sep 24, 2024
@neonene
neonene deleted the byedef2 branch September 26, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@neonene @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.