GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119180: Fix annotationlib.ForwardRef.evaluate with no globals by JelleZijlstra · Pull Request #124326 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Sep 23, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We were sometimes passing None as the globals argument to eval(), which makes it
inherit the globals from the calling scope. Instead, ensure that globals is always
non-None. The test was passing accidentally because I passed "annotationlib" as a
module object; fix that. Also document the parameters to ForwardRef() and remove
two unused private ones.

  • Issue: Implement PEP 649 and PEP 749 #119180

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JelleZijlstra added 2 commits September 22, 2024 14:25
@JelleZijlstra
pythongh-119180: Fix bug where fwdrefs were evaluated in the annotati…
293fb0a 
…onlib module scope

We were sometimes passing None as the globals argument to eval(), which makes it
inherit the globals from the calling scope. Instead, ensure that globals is always
non-None. The test was passing accidentally because I passed "annotationlib" as a
module object; fix that. Also document the parameters to ForwardRef() and remove
two unused private ones.
@JelleZijlstra
More tests
4f08276
@JelleZijlstra JelleZijlstra added the skip news label Sep 23, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 23, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 23, 2024
Implement PEP 649 and PEP 749 #119180
Closed
21 of 30 tasks
@JelleZijlstra
JelleZijlstra requested a review from AlexWaygood September 23, 2024 14:17
@JelleZijlstra JelleZijlstra mentioned this pull request Sep 23, 2024
gh-119180: Avoid going through AST and eval() when possible in annotationlib #124337
Merged
AlexWaygood
AlexWaygood approved these changes Sep 23, 2024
View reviewed changes
Comment thread Lib/annotationlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 23, 2024
@JelleZijlstra @AlexWaygood
Update Lib/annotationlib.py
fca05d5 
Co-authored-by: Alex Waygood <[email protected]>
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) September 23, 2024 18:21
@JelleZijlstra
JelleZijlstra merged commit 2e0d445 into python:main Sep 23, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.