GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-124296: Remove private dictionary version tag (PEP 699) by colesbury · Pull Request #124472 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Sep 24, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The remaining uses for tracking dictionary watchers and the tier2 mutation counter are stored in a ma_watcher_tag field.

  • Issue: Remove ma_version_tag (PEP 699 / PEP 509) #124296

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-124296: Remove private dictionary version tag (PEP 699)
043db41
@bedevere-app bedevere-app Bot mentioned this pull request Sep 24, 2024
Remove ma_version_tag (PEP 699 / PEP 509) #124296
Closed
@colesbury colesbury added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Sep 24, 2024
@bedevere-bot

bedevere-bot commented Sep 24, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 043db41 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Sep 24, 2024
@colesbury
colesbury marked this pull request as ready for review September 25, 2024 16:37
@colesbury
colesbury requested review from Fidget-Spinner, ericsnowcurrently, markshannon and methane as code owners September 25, 2024 16:37
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 25, 2024
Fidget-Spinner
Fidget-Spinner approved these changes Sep 27, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 27, 2024
encukou
encukou reviewed Sep 28, 2024
View reviewed changes
Comment thread Include/cpython/dictobject.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
Rename field to _ma_watcher_tag
c8622f4
@colesbury
colesbury merged commit 5aa91c5 into python:main Oct 1, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 1, 2024
@colesbury
colesbury deleted the gh-124296-ma-version-tag branch October 1, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@methane methane Awaiting requested review from methane methane is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@colesbury @bedevere-bot @encukou @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.