GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — GH-124567: Reduce overhead of cycle GC. by markshannon · Pull Request #124717 · python/cpython Conversation
|
|
As a quick preliminary check, I would suggest running doc tests, since they indicated the issue at first and caused further findings (see #118891 for details). Currently, it appears to me that the PR achieves the opposite of its purpose. Doctest on main branch takes ~12-15 minutes |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The test at https://github.com/Privat33r-dev/cpython/actions/runs/11082906901/job/30796516669?pr=4 was killed by the 60 minute timeout, less than half-way through the build (source files not fully read). This PR isn't running documentation tests as no files in A |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
That's how I triggered it in my repo. I suggest to add/remove space in Docs in this PR as well, so we can see the end result of the changes. I probably should've added further context for clarity. I used this PR as a base to make a PR in my repository, with 1 more commit from me (space change in docs), so Doctest will start automatically. It took more than 1 hour and stopped halfway through, because the job had 1 hour limit set. At the same time, I made a control Doctest in my repo on main branch + minor doc change. It took 13 m: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| gc_list_merge(&survivors, visited); | ||
| assert(gc_list_is_empty(&increment)); | ||
| gcstate->work_to_do += gcstate->heap_size / SCAN_RATE_DIVISOR / scale_factor; | ||
| Py_ssize_t delta = (gcstate->heap_size - gcstate->prior_heap_size)*3; |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Binary operations, where two operands require spaces, may be more standard.
(gcstate->heap_size - gcstate->prior_heap_size) * 3
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Closing this, as we don't need an urgent fix (3.13 goes back to generational collection) Longer term, I expect reduced reference counting operations to make faster-cpython/ideas#693 viable. The pre-scan to find live objects is definitely worth further investigation, though. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.