GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-66436: Improved prog default value for argparse.ArgumentParser by serhiy-storchaka · Pull Request #124799 · python/cpython

Conversation

serhiy-storchaka commented Sep 30, 2024 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

It can now have one of three forms:

basename(argv0) -- for simple scripts
python arv0 -- for directories, ZIP files, etc
python -m module -- for imported modules

Issue: argparse support for "python -m module" in help #66436

📚 Documentation preview 📚: https://cpython-previews--124799.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka requested a review from ncoghlan

September 30, 2024 19:32

serhiy-storchaka requested review from brettcannon, ericsnowcurrently and warsaw as code owners

September 30, 2024 19:33

bedevere-app Bot added the awaiting core review label

Sep 30, 2024

bedevere-app Bot mentioned this pull request

Sep 30, 2024

argparse support for "python -m module" in help #66436

Closed


          pythongh-66436: Improved prog default value for argparse.ArgumentParser

It can now have one of three forms:

* basename(argv0) -- for simple scripts
* python arv0 -- for directories, ZIP files, etc
* python -m module -- for imported modules

serhiy-storchaka force-pushed the argparse-default-prog-name branch from 5ba9a91 to 1977630 Compare

September 30, 2024 19:52

serhiy-storchaka commented

Sep 30, 2024

View reviewed changes

Comment thread

Lib/argparse.py Outdated

Comment on lines +1708 to +1709

		if (modspec.name == '__main__' and not modspec.parent and modspec.has_location
		and _os.path.dirname(modspec.origin) == _os.path.join(_os.getcwd(), arg0)):

serhiy-storchaka Sep 30, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it seems that this condition can be simplified to simply modspec.name == '__main__'. What are your thoughts @ncoghlan?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka Oct 1, 2024

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, additionally checks were just an obstacle, because of differences in normalization between Unix and Windows. So I removed them.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka added 5 commits

October 1, 2024 09:09


          Fix encoding/decoding errors on Windows.

58cbd64


          Simplify the the code and fix the directory test on Windows.

291b6cf


          Fix test_calendar.

93c7a80


          Try to fix test_parent_help on CI.

0b72da9


          Fix test_embed.

5f62bbd

ncoghlan approved these changes

Oct 1, 2024

View reviewed changes

ncoghlan left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Assorted minor comments inline, either tweaking docs wording, or else making the code handle obscure edge cases more gracefully.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Apply suggestions from code review

99c7d98

Co-authored-by: Alyssa Coghlan <[email protected]>

serhiy-storchaka commented

Oct 1, 2024

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestions @ncoghlan. I applied them all.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/argparse.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka mentioned this pull request

Oct 1, 2024

import_helper.make_legacy_pyc() works incorrectly for source files in a directory #124842

Closed

serhiy-storchaka added 2 commits

October 1, 2024 19:06


          Update Lib/argparse.py

92b9d07


          Merge branch 'main' into argparse-default-prog-name

f6810ee

serhiy-storchaka removed request for brettcannon, ericsnowcurrently and warsaw

October 1, 2024 16:09


          Try to fix other test on Windows CI.

1f0bfc1

serhiy-storchaka merged commit 04bfea2 into python:main

Oct 1, 2024

bedevere-app Bot removed the awaiting merge label

Oct 1, 2024

serhiy-storchaka deleted the argparse-default-prog-name branch

October 1, 2024 19:51

effigies mentioned this pull request

Mar 10, 2026

fix: Adjust tests to not depend on how pytest is invoked nipy/nibabel#1478

Merged

Reviewers

ncoghlan

ncoghlan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Sep 30, 2024 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Oct 1, 2024

Choose a reason for hiding this comment

Uh oh!

ncoghlan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

serhiy-storchaka commented Sep 30, 2024 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka Sep 30, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.