GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-125323: Convert DECREF_INPUTS_AND_REUSE_FLOAT into a function that takes PyStackRefs. by markshannon · Pull Request #125439 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Oct 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Unsafe DECREFs of borrowed references in the interpreter. #125323

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Convert DECREF_INPUTS_AND_REUSE_FLOAT into a function that takes PySt…
07df2d0 
…ackRefs.
@bedevere-app bedevere-app Bot mentioned this pull request Oct 14, 2024
Unsafe DECREFs of borrowed references in the interpreter. #125323
Closed
@markshannon markshannon added the skip news label Oct 14, 2024
Fidget-Spinner
Fidget-Spinner reviewed Oct 14, 2024
View reviewed changes
Comment thread Objects/floatobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
Make sure that _PyFloat_FromDouble_ConsumeInputs is safe in the no-gi…
94273bf 
…l build
Fidget-Spinner
Fidget-Spinner approved these changes Oct 14, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label Oct 14, 2024
@markshannon
markshannon marked this pull request as ready for review October 14, 2024 13:15
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting merge labels Oct 14, 2024
@markshannon

markshannon commented Oct 14, 2024

Copy link
Copy Markdown
Member Author

Performance numbers show no change on Windows, and an insignificant change on linux. No obvious slowdown on any of the floating point benchmarks, which is where any real effect would show up.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
markshannon merged commit 06ca330 into python:main Oct 14, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@markshannon @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.