GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959) by graingert · Pull Request #125466 · python/cpython

Conversation

@graingert

@graingert graingert commented Oct 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: refcycles in exceptions raised from asyncio.TaskGroup #124958

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@graingert
pythongh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (pytho…
6d7698c 
…n#124959)
@bedevere-app bedevere-app Bot mentioned this pull request Oct 14, 2024
refcycles in exceptions raised from asyncio.TaskGroup #124958
Closed
@graingert graingert changed the title gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959) [3.12] gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959) Oct 14, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 14, 2024
gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles #124959
Merged
@graingert graingert closed this Oct 14, 2024
@graingert graingert reopened this Oct 14, 2024
@graingert
graingert marked this pull request as ready for review October 14, 2024 15:45
@graingert
graingert requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners October 14, 2024 15:45
@bedevere-app bedevere-app Bot added the awaiting review label Oct 14, 2024
@kumaraditya303 kumaraditya303 added the DO-NOT-MERGE label Oct 14, 2024
@graingert graingert removed the DO-NOT-MERGE label Oct 14, 2024
@graingert
Merge branch '3.12' into backport-d5dbbf4-3.12
0ae2c31
@1st1

1st1 commented Oct 15, 2024

Copy link
Copy Markdown
Member

What's this DO NOT MERGE label business?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graingert

graingert commented Oct 16, 2024

Copy link
Copy Markdown
Contributor Author

What's this DO NOT MERGE label business?

@1st1 this was related to a failure on 3.14 (main) caused by a conflict with a different PR #124392

The do not merge label was added out of an abundance of caution assuming this PR was flaky when it is not. I removed the label
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graingert
Merge branch '3.12' into backport-d5dbbf4-3.12
c6894b1
@1st1
1st1 merged commit 32d4579 into python:3.12 Oct 17, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 17, 2024
@graingert
graingert deleted the backport-d5dbbf4-3.12 branch October 17, 2024 07:44
@gvanrossum

gvanrossum commented Oct 18, 2024

Copy link
Copy Markdown
Member

What's this DO NOT MERGE label business?

@1st1 this was related to a failure on 3.14 (main) caused by a conflict with a different PR #124392

The do not merge label was added out of an abundance of caution assuming this PR was flaky when it is not. I removed the label

Sure, but please understand not everyone is aware of the reasons, so next time please add a comment to explain. (Also my pet peeve for revert PRs, too few people don’t say why it is being reverted and the OP has to hunt for the reason.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@graingert @1st1 @gvanrossum @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.