GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-125543: Add an internal C API for dynamic arrays by ZeroIntensity · Pull Request #125554 · python/cpython

Conversation

@ZeroIntensity

@ZeroIntensity ZeroIntensity commented Oct 15, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Co-authored-by: Kirill Podoprigora [email protected]

  • Issue: Adding an internal C-API for dynamic arrays #125543

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with eyes emoji
All reactions
  • 👀 1 reaction
ZeroIntensity added 6 commits October 15, 2024 16:23
@ZeroIntensity
Setup build.
111fb4b
@ZeroIntensity
Simple implementation.
6e305d1
@ZeroIntensity
Add to header file.
210d4d2
@ZeroIntensity
Add convenience macros.
2c77397
@ZeroIntensity
Add docstrings and some sanity checks.
d90329a
@ZeroIntensity
Add some simple tests.
3173c08
@bedevere-app bedevere-app Bot mentioned this pull request Oct 15, 2024
Adding an internal C-API for dynamic arrays #125543
Closed
@ZeroIntensity ZeroIntensity added the skip news label Oct 15, 2024
@ZeroIntensity
Clean up tests.
6a8f026
@ZeroIntensity
ZeroIntensity requested a review from Eclips4 October 15, 2024 21:40
ZeroIntensity added 3 commits October 15, 2024 17:43
@ZeroIntensity
Add a test for deallocators.
84a922a
@ZeroIntensity
Boy oh boy do I hate the Windows build system.
caf037c
@ZeroIntensity
Correction: I hate all build systems.
14e46a4
Eclips4
Eclips4 reviewed Oct 15, 2024
View reviewed changes
Comment thread Include/internal/pycore_dynarray.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/dynarray.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
ZeroIntensity added 8 commits October 19, 2024 10:03
@ZeroIntensity
Add set and remove operations.
be1de70
@ZeroIntensity
Add tests for set and remove.
db5adbf
@ZeroIntensity
Update docstrings.
aad50d8
@ZeroIntensity
Add pop.
0ecc65f
@ZeroIntensity
Add tests for pop.
6a46733
@ZeroIntensity
Add insert.
4d732dc
@ZeroIntensity
Add insertion.
95c7753
@ZeroIntensity
Add more heap tests and fix insertion.
51664b8
@ZeroIntensity
ZeroIntensity marked this pull request as ready for review October 19, 2024 16:33
@ZeroIntensity
ZeroIntensity requested review from a team and erlend-aasland as code owners October 19, 2024 16:33
@bedevere-app bedevere-app Bot added the awaiting review label Oct 19, 2024
ZeroIntensity and others added 2 commits October 19, 2024 12:38
@ZeroIntensity
Don't use GCC extension.
b2be58f
@Eclips4
> instead of >=
a24fec2
Eclips4
Eclips4 reviewed Oct 19, 2024
View reviewed changes
Comment thread Python/dynarray.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/dynarray.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity
Fix behavior upon allocation failure.
23902f9
@ZeroIntensity
Remove useless comment.
86f78c6
Eclips4
Eclips4 approved these changes Oct 19, 2024
View reviewed changes

@Eclips4 Eclips4 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation and API look good to me. Let's see what others think.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ZeroIntensity reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 19, 2024
@Eclips4
Eclips4 requested a review from vstinner October 19, 2024 21:17
vstinner
vstinner requested changes Oct 19, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, I'm not convinced that there is a need for such API. I suggest to discuss it on the issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting merge labels Oct 19, 2024
@bedevere-app

bedevere-app Bot commented Oct 19, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner requested changes
@Eclips4 Eclips4 Eclips4 approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ZeroIntensity @vstinner @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.