GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] [3.13] gh-52551: Fix encoding issues in strftime() (GH-125193) (GH-125657) by miss-islington · Pull Request #125661 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 17, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix time.strftime(), the strftime() method and formatting of the
datetime classes datetime, date and time.

  • Characters not encodable in the current locale are now acceptable in
    the format string.
  • Surrogate pairs and sequence of surrogatescape-encoded bytes are no
    longer recombinated.
  • Embedded null character no longer terminates the format string.

This fixes also gh-78662 and gh-124531.

(cherry picked from commit 08ccbb9)

Co-authored-by: Serhiy Storchaka [email protected]
(cherry picked from commit ad3eac1)

  • Issue: time.strftime() and Unicode characters on Windows #52551

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @miss-islington
[3.13] pythongh-52551: Fix encoding issues in strftime() (pythonGH-12…
a34caba 
…5193) (pythonGH-125657)

Fix time.strftime(), the strftime() method and formatting of the
datetime classes datetime, date and time.

* Characters not encodable in the current locale are now acceptable in
  the format string.
* Surrogate pairs and sequence of surrogatescape-encoded bytes are no
  longer recombinated.
* Embedded null character no longer terminates the format string.

This fixes also pythongh-78662 and pythongh-124531.

(cherry picked from commit 08ccbb9)

Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit ad3eac1)
@miss-islington
miss-islington requested review from abalkin and pganssle as code owners October 17, 2024 19:48
@bedevere-app bedevere-app Bot added the awaiting review label Oct 17, 2024
This was referenced Oct 17, 2024
time.strftime() and Unicode characters on Windows #52551
Closed
[3.13] gh-52551: Fix encoding issues in strftime() (GH-125193) #125657
Merged
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) October 17, 2024 19:49
@serhiy-storchaka
serhiy-storchaka merged commit 232b303 into python:3.12 Oct 17, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 17, 2024
@miss-islington
miss-islington deleted the backport-08ccbb9-3.12 branch January 2, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.