GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-125590: Allow FrameLocalsProxy to delete and pop keys from extra locals (GH-125616) by miss-islington · Pull Request #125797 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 5b7a872)

Co-authored-by: Tian Gao [email protected]

  • Issue: it's no longer possible to delete items from f_locals (FrameLocalsProxy) in 3.13+ #125590

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gaogaotiantian @miss-islington
pythongh-125590: Allow FrameLocalsProxy to delete and pop keys from e…
80ff0f0
…xtra locals (pythonGH-125616)

(cherry picked from commit 5b7a872)

Co-authored-by: Tian Gao <[email protected]>
@miss-islington
miss-islington requested a review from markshannon as a code owner October 21, 2024 16:42
@bedevere-app bedevere-app Bot added the awaiting review label Oct 21, 2024
This was referenced Oct 21, 2024
it's no longer possible to delete items from f_locals (FrameLocalsProxy) in 3.13+ #125590
Closed
gh-125590: Allow FrameLocalsProxy to delete and pop keys from extra locals #125616
Merged
@gaogaotiantian
gaogaotiantian enabled auto-merge (squash) October 21, 2024 16:52
@gaogaotiantian
gaogaotiantian merged commit 829d650 into python:3.13 Oct 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 21, 2024
Vako111
Vako111 reviewed Oct 22, 2024
View reviewed changes

@Vako111 Vako111 left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@miss-islington
miss-islington deleted the backport-5b7a872-3.13 branch January 2, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
1 more reviewer
@Vako111 Vako111 Vako111 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @Vako111 @gaogaotiantian
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.