GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-125783: Add tests to prevent regressions with the combination of `ctypes` and metaclasses. (GH-125881) by miss-islington · Pull Request #125988 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 25, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 1384409)

Co-authored-by: Jun Komoda [email protected]

  • Issue: Add tests to prevent regressions with the combination of ctypes and metaclasses. #125783

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@junkmd @miss-islington
pythongh-125783: Add tests to prevent regressions with the combinatio…
ad5349e 
…n of `ctypes` and metaclasses. (pythonGH-125881)

(cherry picked from commit 1384409)

Co-authored-by: Jun Komoda <[email protected]>
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Oct 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 25, 2024
Add tests to prevent regressions with the combination of ctypes and metaclasses. #125783
Closed
@bedevere-app bedevere-app Bot added awaiting review skip news topic-ctypes labels Oct 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 25, 2024
gh-125783: Add tests to prevent regressions with the combination of ctypes and metaclasses. #125881
Merged
@junkmd

junkmd commented Oct 26, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Unlike main and 3.13, 3.12 does not yet include the test_ctypes._support module, which is causing test failures.

I think a maintainer with the appropriate permissions needs to do such as git checkout 1384409 -- Lib/test/test_ctypes/_support.py on this branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@junkmd junkmd mentioned this pull request Oct 26, 2024
Supporting Python 3.13 enthought/comtypes#618
Closed
@encukou

encukou commented Oct 28, 2024

Copy link
Copy Markdown
Member

I'll try backporting all of #113727.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aisk @erlend-aasland @encukou
Add test_ctypes/_support.py
dd7600e 
This partially backports be89ee5
(python#113727)

Co-authored-by: Erlend E. Aasland <[email protected]>
@encukou

encukou commented Oct 28, 2024

Copy link
Copy Markdown
Member

Nope, too invasive. I'll add _support.py as suggested. If we backport the whole commit later, _support.py shouldn't conflict with it.
junkmd reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit bce9df9 into python:3.12 Oct 29, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 29, 2024
@miss-islington
miss-islington deleted the backport-1384409-3.12 branch January 2, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-ctypes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @junkmd @encukou @aisk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.