GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126008: Fix the type of return value for `ttk.Widget.cget` by Xiaokang2022 · Pull Request #126102 · python/cpython

Conversation

@Xiaokang2022

@Xiaokang2022 Xiaokang2022 commented Oct 29, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR simply converts part of the return value of the ttk.Widget.cget to str type and returns it.

  • Issue: Tkinter ttk widgets cget() returning _tkinter.Tcl_Obj instead of str #126008

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Xiaokang2022
fix: ttk.Widget.cget has an incorrect return value type
c9f7095
@bedevere-app bedevere-app Bot added the awaiting review label Oct 29, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 29, 2024
Tkinter ttk widgets cget() returning _tkinter.Tcl_Obj instead of str #126008
Closed
@Xiaokang2022
style
f6281f8
@Xiaokang2022
Xiaokang2022 marked this pull request as draft October 29, 2024 02:51
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 29, 2024
Xiaokang2022 and others added 2 commits October 29, 2024 11:03
@Xiaokang2022
Fixed some bugs
3cfd9ff
@blurb-it
📜🤖 Added by blurb_it.
194c0d5
@Xiaokang2022
Xiaokang2022 marked this pull request as ready for review October 29, 2024 03:33
@bedevere-app bedevere-app Bot added the awaiting review label Oct 29, 2024
@Xiaokang2022
fix lint
c040d1c
rruuaanng
rruuaanng reviewed Oct 29, 2024
View reviewed changes
Comment thread Lib/tkinter/ttk.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
rruuaanng
rruuaanng reviewed Oct 29, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2024-10-29-03-32-28.gh-issue-126008.wcuSmo.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Oct 29, 2024
View reviewed changes
Comment thread Lib/tkinter/ttk.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Oct 29, 2024
View reviewed changes
Comment thread Lib/tkinter/ttk.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Xiaokang2022 added 5 commits October 30, 2024 03:35
@Xiaokang2022
style
9f0e79a
@Xiaokang2022
Merge branch 'main' into fix-ttk-cget
fb44bef
@Xiaokang2022
test: Add a simple test for ttk.Widget.cget
15cac99
@Xiaokang2022
test: Fix tests
aae1a3d
@Xiaokang2022
Merge branch 'main' into fix-ttk-cget
d6303ff
@ZeroIntensity ZeroIntensity added the topic-tkinter label Jan 10, 2025
@serhiy-storchaka

serhiy-storchaka commented May 2, 2025

Copy link
Copy Markdown
Member

Thank you for your PR, @Xiaokang2022, but I think that this is a documentation issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka closed this May 2, 2025
@Xiaokang2022
Xiaokang2022 deleted the fix-ttk-cget branch May 2, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments
+1 more reviewer
@rruuaanng rruuaanng rruuaanng left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review topic-tkinter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Xiaokang2022 @serhiy-storchaka @picnixz @rruuaanng @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.