GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-126491: Increase the threshold for the GC fast cycle test. by freakboy3742 · Pull Request #126984 · python/cpython

Conversation

@freakboy3742

@freakboy3742 freakboy3742 commented Nov 18, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

#126502 Modified added an improvement to the behavior of the garbage collector, along with a test to verify that behavior. However, that test fails on iOS and Android (and quite possibly any test run that runs the test suite sequentially); the test imposes a limit of 25k objects, but iOS and Android both generate 25032 objects.

The 32 extra object count seems to be something baked in - if you increase the iteration count of the test to 100k, you get the same 25032 object count on iOS and Android.

Following this comment, this PR increases the threshold to 26k 27k.

  • Issue: Mark all objects reachable from roots as live before doing main cyclic GC pass #126491

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@freakboy3742
Increase the threshold for the GC fast cycle test.
af3c692
@freakboy3742 freakboy3742 added the skip news label Nov 18, 2024
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Nov 18, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 18, 2024
Mark all objects reachable from roots as live before doing main cyclic GC pass #126491
Open
@freakboy3742

freakboy3742 commented Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot iOS

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Nov 18, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit af3c692 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742

freakboy3742 commented Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot Android

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Nov 18, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit af3c692 🤖

The command will test the builders whose names match following regular expression: Android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742 freakboy3742 mentioned this pull request Nov 18, 2024
GH-126491: GC: Mark objects reachable from roots before doing cycle collection #126502
Merged
@freakboy3742
freakboy3742 requested review from hugovk and markshannon November 18, 2024 22:23
@hugovk

hugovk commented Nov 18, 2024

Copy link
Copy Markdown
Member

There's still a test_incremental_gc_handles_fast_cycle_creation failure on iOS/Android.

(When this is passing, let's queue up a full buildbot session with the 🔨 test-with-buildbots or refleaks label as well.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742
Increase threshold to 27k.
9d5a064
@freakboy3742

freakboy3742 commented Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

There's still a test_incremental_gc_handles_fast_cycle_creation failure on iOS/Android.

... wat? Now they're both failing with the same count of 26250? I'll bump to 27k as originally suggested... but Murphy being who he is, I'm guessing that means they'll now both fail with a count 27300... 🤣

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742

freakboy3742 commented Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

!builbot iOS

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742

freakboy3742 commented Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot Android

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Nov 18, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 9d5a064 🤖

The command will test the builders whose names match following regular expression: Android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742

freakboy3742 commented Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot iOS

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Nov 18, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 9d5a064 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742

freakboy3742 commented Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

Looks like Bevedere has obliged us with a full buildbot pass regardless...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742

freakboy3742 commented Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

Ok... I was kidding when I predicted the test failure mode... What on earth is going on?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742

freakboy3742 commented Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

I think I see what is going on now. My original assertion that increasing the loop count to 100k didn't change anything was based on having the assertion still set at 25k, and seeing the same 25,032 failure count. I see now that the GC count is increasing with more iterations. Checking now to see how high the threshold actually is...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742

freakboy3742 commented Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

After further testing, it looks like the limit is a lot more than 30k... but the good news (for me) is that I can reproduce the problem on macOS. Closing this PR; I'll put notes back in the original ticket.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742 freakboy3742 closed this Nov 19, 2024
@freakboy3742
freakboy3742 deleted the gc-fast-cycle-fix branch November 19, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon
@hugovk hugovk Awaiting requested review from hugovk

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@freakboy3742 @bedevere-bot @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.