GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-30156: Fix a crash in debug build when PYTHONDUMPREFS is set. by serhiy-storchaka · Pull Request #1272 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Apr 24, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Apply an alternate patch from bpo-26811.

https://bugs.python.org/issue30156

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-30156: Fix a crash in debug build when PYTHONDUMPREFS is set.
feedc86 
Apply an alternate patch from bpo-26811.
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.5 labels Apr 24, 2017
@serhiy-storchaka
serhiy-storchaka requested a review from vstinner April 24, 2017 18:46
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 24, 2017
@mention-bot

mention-bot commented Apr 24, 2017

Copy link
Copy Markdown

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tim-one, @benjaminp and @tiran to be potential reviewers.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner requested changes Apr 24, 2017
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion on the issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka

serhiy-storchaka commented Apr 25, 2017

Copy link
Copy Markdown
Member Author

Excuse me, @Haypo, I have not understood what changes did you request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Apr 25, 2017

Copy link
Copy Markdown
Member

"See discussion on the issue." means see my comment on the issue: http://bugs.python.org/issue30156#msg292239 Basically, I asked if the optimization is worth it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
Merge branch 'master' into property-cached-args-set-size-0
a240af0
@brettcannon brettcannon removed the needs backport to 3.5 label Aug 11, 2017
@Mariatta Mariatta added needs rebase and removed needs rebase labels Oct 9, 2017
serhiy-storchaka added 2 commits October 12, 2017 23:46
@serhiy-storchaka
Move the NEWS entry to NEWS.d/.
719d46a
@serhiy-storchaka
Merge branch 'master' into property-cached-args-set-size-0
d2436a5
@brettcannon

brettcannon commented Feb 2, 2018

Copy link
Copy Markdown
Member

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon brettcannon added the awaiting changes label Feb 2, 2018
@vstinner

vstinner commented Oct 1, 2018

Copy link
Copy Markdown
Member

I removed the optimization instead: PR #9541.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Oct 1, 2018
@serhiy-storchaka
serhiy-storchaka deleted the property-cached-args-set-size-0 branch July 1, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@serhiy-storchaka @mention-bot @vstinner @brettcannon @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.