GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-127321: Avoid stopping at an opcode without an associated line number for breakpoint() (GH-127457) by gaogaotiantian · Pull Request #127487 · python/cpython

Conversation

@gaogaotiantian

@gaogaotiantian gaogaotiantian commented Dec 1, 2024 •
edited by picnixz
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 1bc4f07)

  • Issue: Setting f_trace_opcodes to True can lead to f_lineno being removed in some cases (using breakpoint()/pdb.set_trace()) #127321

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CalmaKarma reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@gaogaotiantian
[3.13] pythongh-127321: Avoid stopping at an opcode without an associ…
4f136c9 
…ated line number for breakpoint() (pythonGH-127457)

(cherry picked from commit 1bc4f07)

Co-authored-by: Tian Gao <[email protected]>
@gaogaotiantian
gaogaotiantian requested a review from iritkatriel December 1, 2024 17:17
@bedevere-app bedevere-app Bot mentioned this pull request Dec 1, 2024
Setting f_trace_opcodes to True can lead to f_lineno being removed in some cases (using breakpoint()/pdb.set_trace()) #127321
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 1, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 1, 2024
gh-127321: Avoid stopping at an opcode without an associated line number for breakpoint() #127457
Merged
@picnixz picnixz changed the title [3.13] gh-127321: Avoid stopping at an opcode without an associated l… [3.13] gh-127321: Avoid stopping at an opcode without an associated line number for breakpoint() (GH-127457) Dec 1, 2024
iritkatriel
iritkatriel approved these changes Dec 1, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 1, 2024
@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error and removed awaiting merge labels Dec 1, 2024
@gaogaotiantian

gaogaotiantian commented Dec 1, 2024

Copy link
Copy Markdown
Member Author

@iritkatriel is the bug label intentional? The test failure does not seem to be related.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented Dec 1, 2024

Copy link
Copy Markdown
Member

It's to say this is a bugfix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gaogaotiantian

gaogaotiantian commented Dec 1, 2024

Copy link
Copy Markdown
Member Author

Ah, okay. I'll merge this after CI finishes then.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added the awaiting merge label Dec 1, 2024
@gaogaotiantian
gaogaotiantian merged commit dd2ad70 into python:3.13 Dec 1, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 1, 2024
@gaogaotiantian
gaogaotiantian deleted the backport-1bc4f07-3.13 branch December 1, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gaogaotiantian @iritkatriel @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.