GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126004: fix positions handling in `codecs.backslashreplace_errors` by picnixz · Pull Request #127676 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Dec 6, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Incorrect handling of start and end values in codecs error handlers #126004

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 2 commits December 6, 2024 11:38
@picnixz
fix codecs.backslashreplace_errors
c85e59c
@picnixz
blurb
cfc4c9b
@bedevere-app bedevere-app Bot mentioned this pull request Dec 6, 2024
Incorrect handling of start and end values in codecs error handlers #126004
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Dec 6, 2024
picnixz added 2 commits December 6, 2024 11:59
@picnixz
fix warnings
2649ab7
@picnixz
cosmetic changes
9558928
@picnixz
picnixz requested a review from encukou December 6, 2024 16:13
picnixz added 2 commits January 3, 2025 13:59
@picnixz
Merge remote-tracking branch 'upstream/main' into fix/codecs/backslas…
11a9431 
…hreplace-errors-126004
@picnixz
use internal _PyUnicodeError_GetParams helper
08be0a7
picnixz
picnixz commented Jan 3, 2025
View reviewed changes
Comment thread Python/codecs.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz added 7 commits January 3, 2025 19:41
@picnixz
Update Python/codecs.c
564ba70
@picnixz
Merge branch 'main' into fix/codecs/backslashreplace-errors-126004
450af5d
@picnixz
Merge branch 'main' into fix/codecs/backslashreplace-errors-126004
e3ebbde
@picnixz
update usages of _PyUnicodeError_GetParams
da54d9b
@picnixz
amend some cosmetic changes to be consistent
98b4ec0
@picnixz
fix bounds
a19b4e3
@picnixz
Merge branch 'main' into fix/codecs/backslashreplace-errors-126004
b585bf0
@picnixz
picnixz requested a review from vstinner January 23, 2025 10:44
vstinner
vstinner reviewed Jan 23, 2025
View reviewed changes
Comment thread Python/codecs.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
leave optimization to the compiler
3eff7b8
vstinner
vstinner reviewed Jan 23, 2025
View reviewed changes
Comment thread Python/codecs.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
remove magic constants
5e5ecbc
@picnixz
picnixz requested a review from vstinner January 23, 2025 12:29
vstinner
vstinner approved these changes Jan 23, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 23, 2025
@picnixz
picnixz merged commit 25a614a into python:main Jan 23, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 23, 2025
@picnixz
picnixz deleted the fix/codecs/backslashreplace-errors-126004 branch January 23, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.