GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126004: remove redundant safeguards for codecs handlers tests by picnixz · Pull Request #127680 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Dec 6, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Incorrect handling of start and end values in codecs error handlers #126004

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
allow to mark codecs handlers tests as safe
ce397ae
@picnixz picnixz added the skip news label Dec 6, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 6, 2024
Incorrect handling of start and end values in codecs error handlers #126004
Closed
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Dec 6, 2024
encukou
encukou reviewed Dec 6, 2024
View reviewed changes
Comment thread Lib/test/test_capi/test_codecs.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
upgrade tests
2216181
@picnixz
picnixz requested a review from encukou December 28, 2024 10:17
@encukou

encukou commented Jan 6, 2025

Copy link
Copy Markdown
Member

I'd prefer merging this after the 3 fixes; at that point this would add additional assertions and remove the safe argument.
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
Merge branch 'main' into fix/codecs/safe-handlers-126004
1f543c7
@picnixz picnixz changed the title gh-126004: allow to mark codecs handlers tests as safe gh-126004: remove safeguards for crashing codecs handlers Jan 23, 2025
@picnixz picnixz changed the title gh-126004: remove safeguards for crashing codecs handlers gh-126004: remove redundant safeguards for codecs handlers Jan 23, 2025
@picnixz picnixz changed the title gh-126004: remove redundant safeguards for codecs handlers gh-126004: remove redundant safeguards for codecs handlers tests Jan 23, 2025
picnixz added 2 commits January 23, 2025 14:33
@picnixz
remove redundant safeguards
d6bc869
@picnixz
add double blank line
2e7f323
@picnixz
picnixz requested a review from vstinner January 23, 2025 13:57
vstinner
vstinner approved these changes Jan 23, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 23, 2025
@picnixz
picnixz merged commit cf0b2da into python:main Jan 23, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 23, 2025
@picnixz
picnixz deleted the fix/codecs/safe-handlers-126004 branch January 23, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@picnixz @encukou @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.