GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-127906: Fix Py_BUILD_ASSERT_EXPR() on Windows by vstinner · Pull Request #127994 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Dec 16, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Change Py_BUILD_ASSERT_EXPR implementation on Windows to avoid a compiler warning about an unnamed structure.

  • Issue: [tests] Backport test_cext and test_cppext (C API tests) from main to the 3.12 branch #127906

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-127906: Fix Py_BUILD_ASSERT_EXPR() on Windows
9c09839 
Change Py_BUILD_ASSERT_EXPR implementation on Windows to avoid a
compiler warning about an unnamed structure.
@vstinner vstinner added skip news topic-C-API labels Dec 16, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 16, 2024
[tests] Backport test_cext and test_cppext (C API tests) from main to the 3.12 branch #127906
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 16, 2024
@vstinner

vstinner commented Dec 16, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Fix the following test_cext warning treated as an error:

  extension.c(56): error C2220: the following warning is treated as an error
  extension.c(56): warning C4116: unnamed type definition in parentheses
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Dec 16, 2024

Copy link
Copy Markdown
Member Author

I tested locally that this change fix python -m test test_cext -m test_build -v -u all -m test_build_c11.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner enabled auto-merge (squash) December 16, 2024 17:15
@vstinner

vstinner commented Dec 16, 2024

Copy link
Copy Markdown
Member Author

Python 3.12 is not impacted. The main branch already contains the fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 8e143b2 into python:3.13 Dec 16, 2024
@vstinner
vstinner deleted the build_assert_expr13 branch December 16, 2024 17:17
@bedevere-app bedevere-app Bot removed the awaiting core review label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.