GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-128030: Avoid error from PyModule_GetFilenameObject for non-module (GH-128047) by miss-islington · Pull Request #128114 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Dec 20, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I missed the extra PyModule_Check in GH-127660 because I was looking at
3.12 as the base implementation for import from. This meant that I
missed the PyModuleCheck introduced in GH-112661.
(cherry picked from commit 45e6dd6)

Co-authored-by: Shantanu [email protected]

  • Issue: Regression in 3.13.1 for imports of nonexistant names from CFFI modules #128030

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hauntsaninja @miss-islington
pythongh-128030: Avoid error from PyModule_GetFilenameObject for non-…
76b88e6 
…module (pythonGH-128047)

I missed the extra `PyModule_Check` in pythonGH-127660 because I was looking at
3.12 as the base implementation for import from. This meant that I
missed the `PyModuleCheck` introduced in pythonGH-112661.
(cherry picked from commit 45e6dd6)

Co-authored-by: Shantanu <[email protected]>
@miss-islington
miss-islington requested review from brettcannon, ericsnowcurrently, markshannon, ncoghlan and warsaw as code owners December 20, 2024 08:22
This was referenced Dec 20, 2024
Regression in 3.13.1 for imports of nonexistant names from CFFI modules #128030
Closed
gh-128030: Avoid error from PyModule_GetFilenameObject for non-module #128047
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Dec 20, 2024
@hauntsaninja
hauntsaninja enabled auto-merge (squash) December 20, 2024 08:23
@hauntsaninja
hauntsaninja merged commit f320f74 into python:3.13 Dec 20, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Dec 20, 2024
@miss-islington
miss-islington deleted the backport-45e6dd6-3.13 branch January 2, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.