GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Draft: gh-127119: Faster check for small ints in long_dealloc (debug) by eendebakpt · Pull Request #128187 · python/cpython

Conversation

eendebakpt commented Dec 22, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Issue: Remove redundant small int check in long_dealloc #127119

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

eendebakpt and others added 30 commits

December 4, 2024 21:37


          Faster check for small ints in long_dealloc

cfb70cb


          📜🤖 Added by blurb_it.

426dd09


          Use int immortality bit for small int check


          Merge branch 'small_int_immortal_v2' of github.com:eendebakpt/cpython…

d9c26d3

… into small_int_immortal_v2


          Merge branch 'main' into small_int_immortal_v2

2f73d47


          fix compiler warnings

3b6e1fe


          Merge branch 'small_int_immortal_v2' of github.com:eendebakpt/cpython…

03184a7

… into small_int_immortal_v2


          compiler warnings

5eca812


          some documentation updates

fedc102


          Update Objects/longobject.c

c733d25

Co-authored-by: Bénédikt Tran <[email protected]>


          Merge branch 'small_int_immortal_v2' of github.com:eendebakpt/cpython…

829a595

… into small_int_immortal_v2


          Update Tools/gdb/libpython.py

39da0ea


          tests!

5058e53


          tests!

8a3d00f


          update _PyLong_IsNonNegativeCompact

878207a


          Apply suggestions from code review

068a16a

Co-authored-by: Mark Shannon <[email protected]>


          review comments

a65ec5a


          Merge branch 'small_int_immortal_v2' of github.com:eendebakpt/cpython…

38fe25f

… into small_int_immortal_v2


          spacing

32b6e44


          Merge branch 'main' into small_int_immortal_v2

8543c78


          Update Tools/gdb/libpython.py

e232ca4


          Merge branch 'main' into small_int_immortal_v2

f1ce753


          whitespace

99a2fc7


          Merge branch 'main' into small_int_immortal_v2

f6a76b0


          Apply suggestions from code review


          Merge branch 'main' into small_int_immortal_v2


          Merge branch 'main' into small_int_immortal_v2

d91b6e3


          Update Modules/_testcapi/immortal.c

ebc7e17

Co-authored-by: Mark Shannon <[email protected]>


          Update Modules/_testcapi/immortal.c

aaf110b

Co-authored-by: Mark Shannon <[email protected]>


          Update Include/cpython/longintrepr.h

8fcc1d0

Co-authored-by: Mark Shannon <[email protected]>

eendebakpt added 6 commits

December 22, 2024 16:40


          Merge branch 'main' into small_int_immortal_v2

aff8812


          review comments

ebb0bca


          include pycore_long.h

8d8e794


          header

4a07ba1


          include pycore_long.h

1d5b2e0


          debug build failure

cfb9120

eendebakpt added the DO-NOT-MERGE label

Dec 22, 2024

bedevere-app Bot mentioned this pull request

Dec 22, 2024

Remove redundant small int check in long_dealloc #127119

Closed

bedevere-app Bot added the awaiting review label

Dec 22, 2024

eendebakpt added 2 commits

December 23, 2024 16:21


          Merge branch 'main' into small_int_immortal_v2

b606c09


          fix bug when copying the immortal bit

b4c8444

eendebakpt force-pushed the small_int_immortal_v2_tst branch from d89aa25 to 15023d5 Compare

December 23, 2024 21:03


          test small int test

3a553d1

eendebakpt force-pushed the small_int_immortal_v2_tst branch from 15023d5 to 3a553d1 Compare

December 23, 2024 21:09


          print

62939d1

picnixz commented Dec 24, 2024

Copy link

Copy Markdown

Member

@eendebakpt I'm assuming this is only for CI triggers right? would it make sense to you to convert it into a draft? (just so that I'm not tempted to click on it)

eendebakpt reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

eendebakpt closed this

Dec 24, 2024

picnixz commented Dec 24, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

(You could have kept it opened but thanks for cleaning up the opened PRs xD)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

eendebakpt commented Dec 22, 2024 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

picnixz commented Dec 24, 2024

Uh oh!

picnixz commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eendebakpt commented Dec 22, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

picnixz commented Dec 24, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.