GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-125170: Hard deprecate `PyEval_GetLocals` in 3.14 by xuantengh · Pull Request #128348 · python/cpython

Conversation

@xuantengh

@xuantengh xuantengh commented Dec 30, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR aims to hard deprecate the PyEval_GetLocals API by emitting a deprecated warning. Meanwhile, this also removes the corresponding tests for the API.

If we consider to deprecate PyFrame_FastToLocals and PyFrame_FastToLocalsWithError as well (mentioned in #125170 (comment)), please let me know. I think they can be done together in this PR.

  • Issue: PEP 667 follow-up: hard deprecate PyEval_GetLocals() #125170

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xuantengh
xuantengh requested a review from markshannon as a code owner December 30, 2024 15:44
@bedevere-app bedevere-app Bot mentioned this pull request Dec 30, 2024
PEP 667 follow-up: hard deprecate PyEval_GetLocals() #125170
Open
@bedevere-app bedevere-app Bot added the awaiting review label Dec 30, 2024
ZeroIntensity
ZeroIntensity reviewed Dec 30, 2024
View reviewed changes
Comment thread Python/ceval.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/C_API/2024-12-30-15-45-37.gh-issue-125170.Jdo8RC.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity added the skip news label Dec 30, 2024
@ghost

ghost commented Dec 31, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xuantengh
xuantengh force-pushed the deprecate-getlocals branch 2 times, most recently from 04e97fb to 36c1cd0 Compare December 31, 2024 06:05
ZeroIntensity
ZeroIntensity reviewed Jan 10, 2025
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I haven't fully considered the uses of PyEval_GetLocals. It might better to mark it for removal "in the future" so we can adjust it, rather than being constrained to 3.16.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/ceval.c Outdated
Comment on lines +2602 to +2604
if (PyErr_WarnEx(PyExc_DeprecationWarning,
"PyEval_GetLocals() is deprecated in Python 3.14 "
"and will be removed in 3.16.", 1)) {

@ZeroIntensity ZeroIntensity Jan 10, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the convention for us:

Suggested change
if (PyErr_WarnEx(PyExc_DeprecationWarning,
"PyEval_GetLocals() is deprecated in Python 3.14 "
"and will be removed in 3.16.", 1)) {
if (PyErr_WarnEx(PyExc_DeprecationWarning,
"PyEval_GetLocals() is deprecated in Python 3.14 "
"and will be removed in 3.16.", 1) < 0) {

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZeroIntensity
ZeroIntensity requested a review from gaogaotiantian January 10, 2025 03:18
@gaogaotiantian

gaogaotiantian commented Jan 10, 2025

Copy link
Copy Markdown
Member

I don't think we ever reached to a conclusion on whether/how/when we deprecate this API. @ncoghlan @markshannon
ZeroIntensity and xuantengh reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xuantengh
xuantengh force-pushed the deprecate-getlocals branch from 0460320 to 0c4e6b5 Compare January 12, 2025 13:45
@xuantengh
xuantengh requested a review from ericsnowcurrently as a code owner January 12, 2025 13:45
@xuantengh xuantengh closed this Jan 12, 2025
@xuantengh
xuantengh force-pushed the deprecate-getlocals branch from 0c4e6b5 to 5ace717 Compare January 12, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments
@markshannon markshannon Awaiting requested review from markshannon
@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xuantengh @gaogaotiantian @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.