GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128404: split test_asyncgen.py into tests that require a working socket and tests that do not by graingert · Pull Request #128443 · python/cpython

Conversation

@graingert

@graingert graingert commented Jan 3, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Remove un-necessary socket requirements in async tests #128404

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jan 3, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 3, 2025
Remove un-necessary socket requirements in async tests #128404
Open
@graingert graingert added the skip news label Jan 3, 2025
graingert
graingert commented Jan 3, 2025
View reviewed changes
Comment thread Lib/test/test_asyncgen.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@graingert
graingert marked this pull request as ready for review January 3, 2025 11:47
@bedevere-app bedevere-app Bot added the awaiting review label Jan 3, 2025
@graingert graingert changed the title gh-128404: remove requires_working_socket from some of test_asyncgen.py gh-128404: split test_asyncgen.py into tests that require a working socket and tests that do not Jan 3, 2025
@graingert
graingert requested a review from Eclips4 January 4, 2025 07:18
@github-actions

github-actions Bot commented Apr 20, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 20, 2026
@graingert
graingert force-pushed the remove-requires-working-socket-from-some-of-test-asyncgen branch from 8d86513 to be03eda Compare August 31, 2026 18:49
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Sep 2, 2026
graingert and others added 6 commits September 2, 2026 08:26
@graingert
pythongh-128404: remove requires_working_socket from some of test_asy…
c5f2b6b 
…ncgen.py
@graingert
extract some tests that don't need asyncio from under requires_workin…
b4c561f 
…g_socket
@graingert
Update Lib/test/test_asyncgen.py
b4d6597
@graingert
avoid setting the policy in test_asyngen
0b851a7
@graingert @claude
remove now-unused import_module import
2512c9d 
The last import_module() call site went away when
`asyncio = import_module("asyncio")` became a plain import, leaving
the import orphaned and tripping ruff's F401 in the lint job.

Co-Authored-By: Claude Opus 5 <[email protected]>
@graingert
move test_aiter_callable_errors out from under requires_working_socket
2c74bcf 
It does not use the event loop, so the tearDown assertion that the
loop was used fails when it stays in AsyncGenAsyncioTest.
@graingert
graingert force-pushed the remove-requires-working-socket-from-some-of-test-asyncgen branch from cb65eb5 to 2c74bcf Compare September 2, 2026 07:35
@graingert

graingert commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@Eclips4 I've rebased this and it's ready for review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
graingert added 3 commits September 2, 2026 09:28
@graingert
whitespace/import ordering fixes
facb2e8
@graingert
move more tests that don't need a real event loop
29317ab
@graingert
use a list comprehension in the to_list calls
2c1bab5
@ambv

ambv commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

This PR is superseded by #156808, a newer open pull request for the same issue (gh-128404), and it no longer merges cleanly. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Awaiting requested review from Eclips4

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@graingert @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.