GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127146: Fix test_sysconfidata_json in Emscripten by hoodmane · Pull Request #128545 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Jan 6, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In emscripten, the prefix is different when we build and generate the json file from when we run the test.

  • Issue: Emscripten: Get test suite passing #127146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
pythongh-127146: Fix test_sysconfidata_json in Emscripten
6d02cca 
The prefix is different when we build from when we run the test.
@hoodmane
hoodmane requested a review from FFY00 as a code owner January 6, 2025 12:58
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jan 6, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 6, 2025
Emscripten: Get test suite passing #127146
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jan 6, 2025
@hoodmane
hoodmane requested review from freakboy3742 and removed request for FFY00 January 6, 2025 12:58
@hoodmane hoodmane added the skip news label Jan 6, 2025
@FFY00

FFY00 commented Jan 6, 2025

Copy link
Copy Markdown
Member

The prefixes should be loaded from the Makefile when cross-compiling, which we detect from _PYTHON_PROJECT_BASE being set, which should be the case in make test.

Does sys.base_prefix ever differ from the Makefile value? I am not entirely sure how the Python "installation" works on Emscripten's virtual file system. Can it be present/mounted/installed(?) on a directory other than the one specified in the Makefile? If so, and if that's where this problem stems from, then this isn't an issue specific to Emscripten, but rather all relocatable installations, which is something this test currently does not account for, but it probably should. If this is the problem, then I'd prefer to fix the underlying issue rather than special-case Emscripten.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane

hoodmane commented Jan 6, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I think I found the problem.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane hoodmane closed this Jan 6, 2025
@hoodmane

hoodmane commented Jan 6, 2025

Copy link
Copy Markdown
Contributor Author

Opened #128556 with an actual fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane
hoodmane deleted the sysconfig-test branch January 6, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 Awaiting requested review from freakboy3742

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hoodmane @FFY00
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.