GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128550: TaskGroup: cancel tasks added to set after aborting by graingert · Pull Request #128551 · python/cpython

Conversation

@graingert

@graingert graingert commented Jan 6, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: TaskGroup fails to cancel tasks pending creation, if that task starts a failing task #128550

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot mentioned this pull request Jan 6, 2025
TaskGroup fails to cancel tasks pending creation, if that task starts a failing task #128550
Closed
@graingert
pythongh-128550: TaskGroup: cancel tasks added to set after aborting
9726c3d
@graingert
graingert force-pushed the fix-taskgroup-eager branch from 41929bd to 9726c3d Compare January 6, 2025 16:04
@AlexWaygood AlexWaygood added the topic-asyncio label Jan 6, 2025
@graingert

graingert commented Jan 6, 2025

Copy link
Copy Markdown
Contributor Author

I'm refactoring the tests to run the TaskGroup tests on eager and lazy tasks and have found another issue. I'm afk at the moment and will fix that one shortly too
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graingert

graingert commented Jan 6, 2025

Copy link
Copy Markdown
Contributor Author

Ok I have the other issue here: #128553
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graingert
add test
98b6d01
graingert
graingert commented Jan 6, 2025
View reviewed changes
Comment thread Lib/asyncio/taskgroups.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@graingert
Update Lib/asyncio/taskgroups.py
f983834
graingert
graingert commented Jan 6, 2025
View reviewed changes
Comment thread Lib/test/test_asyncio/test_taskgroups.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert added 2 commits January 6, 2025 18:33
@graingert
Update Lib/test/test_asyncio/test_taskgroups.py
6f661be
@graingert
Merge branch 'main' into fix-taskgroup-eager
ca5593b
graingert
graingert commented Jan 6, 2025
View reviewed changes
Comment thread Lib/test/test_asyncio/test_taskgroups.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@blurb-it
📜🤖 Added by blurb_it.
1f3e028
@graingert
graingert requested a review from ZeroIntensity January 6, 2025 18:58
@graingert
graingert marked this pull request as ready for review January 6, 2025 18:58
@graingert
graingert requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners January 6, 2025 18:58
@bedevere-app bedevere-app Bot added the awaiting review label Jan 6, 2025
@graingert
Merge branch 'main' into fix-taskgroup-eager
dfdee7d
ZeroIntensity
ZeroIntensity reviewed Jan 6, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-01-06-18-58-07.gh-issue-128550.lzeWhZ.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_asyncio/test_taskgroups.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_asyncio/test_taskgroups.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert
graingert commented Jan 6, 2025
View reviewed changes
Comment thread Lib/test/test_asyncio/test_taskgroups.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@graingert
Update Lib/test/test_asyncio/test_taskgroups.py
b1d15b6
graingert
graingert commented Jan 6, 2025
View reviewed changes
Comment thread Lib/test/test_asyncio/test_taskgroups.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert
graingert commented Jan 6, 2025
View reviewed changes
Comment thread Lib/test/test_asyncio/test_taskgroups.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert and others added 3 commits January 6, 2025 21:23
@graingert
Apply suggestions from code review
b3a20db
@graingert @ZeroIntensity
Update Misc/NEWS.d/next/Library/2025-01-06-18-58-07.gh-issue-128550.l…
b777cf4 
…zeWhZ.rst

Co-authored-by: Peter Bierma <[email protected]>
@graingert
Merge branch 'main' into fix-taskgroup-eager
b09c9e0
ZeroIntensity
ZeroIntensity approved these changes Jan 7, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Jan 7, 2025
@graingert
Merge branch 'main' into fix-taskgroup-eager
58445e7
@kumaraditya303
kumaraditya303 requested a review from gvanrossum January 7, 2025 15:03
@graingert
Merge branch 'main' into fix-taskgroup-eager
c4842d9
@graingert graingert closed this Jan 20, 2025
@graingert
graingert deleted the fix-taskgroup-eager branch January 20, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@graingert @ZeroIntensity @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.