GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-123085: _compile_importlib: Avoid copying sources before compilation (GH-124131) by miss-islington · Pull Request #128581 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 7, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 42c8b05)

Co-authored-by: Petr Viktorin [email protected]
Co-authored-by: Jason R. Coombs [email protected]

  • Issue: importlib.resources.files() doesn't work correctly when importlib library is compiled #123085

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou @jaraco @miss-islington
pythongh-123085: _compile_importlib: Avoid copying sources before com…
1871e2e 
…pilation (pythonGH-124131)

(cherry picked from commit 42c8b05)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Jason R. Coombs <[email protected]>
@miss-islington
miss-islington requested review from FFY00, jaraco and warsaw as code owners January 7, 2025 08:32
@bedevere-app bedevere-app Bot mentioned this pull request Jan 7, 2025
importlib.resources.files() doesn't work correctly when importlib library is compiled #123085
Open
@bedevere-app bedevere-app Bot added the skip news label Jan 7, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 7, 2025
gh-123085: _compile_importlib: Avoid copying sources before compilation #124131
Merged
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Jan 7, 2025
@encukou

encukou commented Jan 7, 2025

Copy link
Copy Markdown
Member

!buildbot x86.Debian.Installed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 7, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 1871e2e 🤖

The command will test the builders whose names match following regular expression: x86.Debian.Installed

The builders matched are:

  • x86 Debian Installed with X PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Jan 7, 2025

Copy link
Copy Markdown
Member

I'll merge this to fix the failing buildbots.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit e758eb3 into python:3.12 Jan 7, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label Jan 7, 2025
@miss-islington
miss-islington deleted the backport-42c8b05-3.12 branch January 2, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @encukou @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.