GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-128552: fix refcycles in eager task creation (#128553) by graingert · Pull Request #128585 · python/cpython

Conversation

@graingert

@graingert graingert commented Jan 7, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 61b9811)

  • Issue: TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception and loop.create_task -> task -> exception #128552

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@graingert
pythongh-128552: fix refcycles in eager task creation (python#128553)
ceaafff 
(cherry picked from commit 61b9811)
@bedevere-app bedevere-app Bot mentioned this pull request Jan 7, 2025
TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception and loop.create_task -> task -> exception #128552
Closed
@graingert graingert changed the title gh-128552: fix refcycles in eager task creation (#128553) [3.13] gh-128552: fix refcycles in eager task creation (#128553) Jan 7, 2025
@bedevere-app bedevere-app Bot added the topic-asyncio label Jan 7, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 7, 2025
gh-128552: fix refcycles in eager task creation #128553
Merged
@graingert
graingert marked this pull request as ready for review January 7, 2025 18:22
@graingert
graingert requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners January 7, 2025 18:22
@bedevere-app bedevere-app Bot added the awaiting review label Jan 7, 2025
@graingert
Merge branch '3.13' into backport-61b9811-3.13
0ccc8a8
kumaraditya303
kumaraditya303 approved these changes Jan 8, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 8, 2025
@kumaraditya303
kumaraditya303 merged commit 1383588 into python:3.13 Jan 8, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 8, 2025
@graingert
graingert deleted the backport-61b9811-3.13 branch January 8, 2025 13:06
@graingert

graingert commented Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

@kumaraditya303 thanks for the review! I'm not sure what to do about the 3.12 backport it looks possibly unfixable?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303

kumaraditya303 commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

Yeah, Python 3.12 is too old now anyways, let's skip it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graingert

graingert commented Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

@kumaraditya303 I'm talking about #128588 seems pretty severe
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@graingert @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.