GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-128588: gh-128550: gh-128552: fix refcycles in eager task creation (#128553) and remove eager tasks optimization that missed and introduced incorrect cancellations (python#129063) by graingert · Pull Request #128586 · python/cpython

Conversation

@graingert

@graingert graingert commented Jan 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 61b9811)

  • Issue: TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception and loop.create_task -> task -> exception #128552
  • Issue: TaskGroup fails to cancel tasks pending creation, if that task starts a failing task #128550
  • Issue: Cancellation leaks out of asyncio.TaskGroup on 3.12 when using eager tasks #128588

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@graingert
pythongh-128552: fix refcycles in eager task creation (python#128553)
5f624a0 
(cherry picked from commit 61b9811)
@bedevere-app bedevere-app Bot mentioned this pull request Jan 7, 2025
TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception and loop.create_task -> task -> exception #128552
Closed
@bedevere-app bedevere-app Bot added the topic-asyncio label Jan 7, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 7, 2025
gh-128552: fix refcycles in eager task creation #128553
Merged
graingert
graingert commented Jan 7, 2025
View reviewed changes
Comment thread Lib/test/test_asyncio/test_taskgroups.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert added 2 commits January 7, 2025 12:24
@graingert
Update Lib/test/test_asyncio/test_taskgroups.py
9df724e
@graingert
remove tests only valid in 3.13
e92aed1
graingert
graingert commented Jan 7, 2025
View reviewed changes
Comment thread Lib/test/test_asyncio/test_taskgroups.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert and others added 3 commits January 20, 2025 12:44
@graingert
Merge branch '3.12' into backport-61b9811-3.12
2246cfa
@graingert
Merge branch '3.12' into backport-61b9811-3.12
958bb1c
@graingert @kumaraditya303
pythongh-128588: pythongh-128550: remove eager tasks optimization tha…
59aff22 
…t missed and introduced incorrect cancellations (python#129063)

Co-authored-by: Kumar Aditya <[email protected]>
@graingert graingert changed the title [3.12] gh-128552: fix refcycles in eager task creation (#128553) [3.12] gh-128588: gh-128550: gh-128552: fix refcycles in eager task creation (#128553) and remove eager tasks optimization that missed and introduced incorrect cancellations (python#129063) Jan 20, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 20, 2025
Cancellation leaks out of asyncio.TaskGroup on 3.12 when using eager tasks #128588
Closed
@graingert
graingert marked this pull request as ready for review January 20, 2025 18:02
@graingert
graingert requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners January 20, 2025 18:02
@bedevere-app bedevere-app Bot added the awaiting review label Jan 20, 2025
kumaraditya303
kumaraditya303 approved these changes Jan 21, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 21, 2025
@kumaraditya303
kumaraditya303 merged commit bc21454 into python:3.12 Jan 21, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 21, 2025
@graingert
graingert deleted the backport-61b9811-3.12 branch January 21, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@graingert @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.