GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-89745: Remove dead realpath branch in getpath.c by pelson · Pull Request #128861 · python/cpython

Conversation

@pelson

@pelson pelson commented Jan 15, 2025 •
edited by picnixz
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The readlink code before is always taking precedence, and I don't know of a platform which has realpath but not readlink.

Note that this is a bit of a speculative change identified when tackling another getpath[.py] issue - I have no broad knowledge of platforms to be 100% certain that realpath without readlink isn't a thing.

  • Issue: Rewrite getpath.c in Python #89745

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pelson
Remove realpath branch in getpath - the readlink code before is alway…
b30c594 
…s taking precedence
@pelson
pelson requested a review from FFY00 as a code owner January 15, 2025 10:05
@bedevere-app bedevere-app Bot added the awaiting review label Jan 15, 2025
@pelson

pelson commented Jan 15, 2025

Copy link
Copy Markdown
Contributor Author

It looks like this came in part in 99fcf15#diff-ad0a6e4fd367f158f5af826b512704cef7808813c3a3a474f9d8a10b5ef75e45.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity added skip issue skip news labels Jan 16, 2025
@pelson

pelson commented Jan 21, 2025

Copy link
Copy Markdown
Contributor Author

@FFY00 and @zooba - is this a worthwhile change? If so, I'm happy to open up an issue, rebase, etc.

If not, I would also be happy to just close the PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz changed the title gh-XXXXX: Remove dead realpath branch in getpath.c gh-89745: Remove dead realpath branch in getpath.c Jan 21, 2025
@picnixz

This comment was marked as resolved.

Sign in to view
@picnixz picnixz mentioned this pull request Jan 21, 2025
Rewrite getpath.c in Python #89745
Closed
@zooba

zooba commented Jan 21, 2025

Copy link
Copy Markdown
Member

I have no broad knowledge of platforms to be 100% certain that realpath without readlink isn't a thing.

Me neither. I'm not confident to remove code that I copy-pasted (I assume from posixmodule.c, possibly from fileutils.c, but I expect if it were there then I could've just called it).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Apr 21, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 21, 2026
@picnixz

picnixz commented Apr 21, 2026

Copy link
Copy Markdown
Member

Closing as we are not entirely sure it is really a dead path.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz closed this Apr 21, 2026
@pelson
pelson deleted the tidy/remove-dead-code branch April 21, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip issue skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pelson @picnixz @zooba @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.