GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121604: fix warnings in test_importlib.test_abc and test_importlib.test_windows by graingert · Pull Request #128904 · python/cpython

Conversation

@graingert

@graingert graingert commented Jan 16, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Make sure all deprecated items in importlib raise DeprecationWarning #121604

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
graingert added 2 commits January 16, 2025 06:50
@graingert
fix warnings in test_importlib.test_abc
ec6a368
@graingert
fix warnings found in test_importlib.test_windows
a5c2b7a
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jan 16, 2025
@graingert graingert changed the title fix warnings in test_importlib.test_abc and test_importlib.test_windows gh-121604: fix warnings in test_importlib.test_abc and test_importlib.test_windows Jan 16, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 16, 2025
Make sure all deprecated items in importlib raise DeprecationWarning #121604
Closed
11 tasks done
@graingert graingert added the skip news label Jan 16, 2025
@graingert
graingert marked this pull request as ready for review January 16, 2025 07:19
@graingert
graingert requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners January 16, 2025 07:19
@bedevere-app bedevere-app Bot added the awaiting review label Jan 16, 2025
brettcannon
brettcannon approved these changes Jan 16, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 16, 2025
@brettcannon
brettcannon merged commit 27494dd into python:main Jan 16, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@graingert @brettcannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.