GeezerVison is showing github.com — gh-127787: allow to retrieved the clipped slice length in `_PyUnicodeError_GetParams` by picnixz · Pull Request #128980 · python/cpython
Conversation
picnixz
commented
Jan 18, 2025
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
I've taken the liberty of adding some assert_* functions just to be always sure that we don't mess up the indices. It's more for the future than for now since the assertions are simple. But I also felt that it'd be nicer to have a function call rather than lots of assert() one after the other.
I also removed some inline qualifiers as they are likely no more inlined (since we are calling an inline function with more than 1 or 2 lines more than once in the same function, I think it's better to let the compiler decide on the inlining itself).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect now! :)
Thank you!
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
You're welcome! Now I can finally do what I wanted to do in the first place (namely fixing the codecs handlers!!)
|
encukou reacted with hooray emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
encukou
encukou approved these changes
iritkatriel
Awaiting requested review from iritkatriel
iritkatriel is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.