GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127787: allow to retrieved the clipped slice length in `_PyUnicodeError_GetParams` by picnixz · Pull Request #128980 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jan 18, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I've taken the liberty of adding some assert_* functions just to be always sure that we don't mess up the indices. It's more for the future than for now since the assertions are simple. But I also felt that it'd be nicer to have a function call rather than lots of assert() one after the other.

I also removed some inline qualifiers as they are likely no more inlined (since we are calling an inline function with more than 1 or 2 lines more than once in the same function, I think it's better to let the compiler decide on the inlining itself).

  • Issue: Refactor PyUnicodeError internal C helpers #127787

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
picnixz added 2 commits January 16, 2025 11:00
@picnixz
Allow to retrieve clipped slice length in _PyUnicodeError_GetParams.
3db8c22
@picnixz
Merge branch 'main' into feat/exc/unicode-get-params-127787
a4efb0a
@picnixz
picnixz requested a review from encukou January 18, 2025 10:14
@picnixz
picnixz requested a review from iritkatriel as a code owner January 18, 2025 10:14
@bedevere-app bedevere-app Bot mentioned this pull request Jan 18, 2025
Refactor PyUnicodeError internal C helpers #127787
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 18, 2025
@picnixz picnixz added the skip news label Jan 18, 2025
encukou
encukou reviewed Jan 20, 2025
View reviewed changes
Comment thread Include/internal/pycore_pyerrors.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

@picnixz
logic simplification
60d6379
@picnixz
picnixz requested a review from encukou January 20, 2025 17:50
encukou
encukou approved these changes Jan 21, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect now! :)
Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 21, 2025
@encukou
encukou merged commit 36f341c into python:main Jan 21, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 21, 2025
@picnixz
picnixz deleted the feat/exc/unicode-get-params-127787 branch January 21, 2025 10:51
@picnixz

picnixz commented Jan 21, 2025

Copy link
Copy Markdown
Member Author

You're welcome! Now I can finally do what I wanted to do in the first place (namely fixing the codecs handlers!!)

encukou reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.