GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: fix UBSan failures in `Modules/_ctypes` by picnixz · Pull Request #129071 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jan 20, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 9 commits January 20, 2025 14:41
@picnixz
fix UBSan failures for DictRemoverObject
9c87ae1
@picnixz
fix UBSan failures for StructParamObject
ec730ba
@picnixz
fix UBSan failures for CDataObject
a604eb7
@picnixz
fix UBSan failures for PyCFuncPtrObject
0014d3d
@picnixz
fix UBSan failures for PyCArgObject
5830275
@picnixz
fix UBSan failures for CFieldObject
e193e6f
@picnixz
remove redundant docstring casts
df5d477
@picnixz
remove redundant PyObject casts
753ba2a
@picnixz
fix compilation errors
441a0be
@picnixz
picnixz requested review from ZeroIntensity and encukou January 20, 2025 14:56
@bedevere-app bedevere-app Bot mentioned this pull request Jan 20, 2025
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 20, 2025
@picnixz picnixz added the skip news label Jan 20, 2025
ZeroIntensity
ZeroIntensity reviewed Jan 20, 2025
View reviewed changes
Comment thread Modules/_ctypes/_ctypes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_ctypes/_ctypes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_ctypes/_ctypes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz added 2 commits January 20, 2025 16:37
@picnixz
consistency & warnings patches
5358251
@picnixz
reduce diff even further
a1f7e5a
picnixz
picnixz commented Jan 20, 2025
View reviewed changes
Comment thread Modules/_ctypes/cfield.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
encukou
encukou reviewed Jan 20, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_ctypes/_ctypes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz added 2 commits January 20, 2025 17:18
@picnixz
keep necessary cast
504eabf
@picnixz
add some new lines
1e51fa7
encukou
encukou approved these changes Jan 20, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Don't worry about making it any prettier.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 20, 2025
@picnixz

picnixz commented Jan 20, 2025

Copy link
Copy Markdown
Member Author

@vstinner I plan to merge this one with no commit message and the PR's title as the commit's title.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Jan 20, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM. I didn't test the change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
picnixz merged commit fafc618 into python:main Jan 21, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 21, 2025
@picnixz
picnixz deleted the fix/ubsan/ctypes-111178 branch January 21, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments
@vstinner vstinner vstinner approved these changes
@encukou encukou encukou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@picnixz @vstinner @encukou @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.