GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: fix UBSan failures in `Modules/_io/*.c` by picnixz · Pull Request #129083 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jan 20, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 10 commits January 20, 2025 16:26
@picnixz
fix UBSan failures for buffered
37bc556
@picnixz
fix UBSan failures for rwpair
36f5adc
@picnixz
fix UBSan failures for bytesio
2a02293
@picnixz
fix UBSan failures for bytesiobuf
fc3cd12
@picnixz
fix UBSan failures for iobase
cd728f5
@picnixz
fix UBSan failures for stringio
0da5a81
@picnixz
fix UBSan failures for nldecoder_object
9889af8
@picnixz
fix UBSan failures for textio
19ed68d
@picnixz
fix UBSan failures for winconsoleio
249ec3e
@picnixz
reduce diff
cf44141
@picnixz picnixz added the skip news label Jan 20, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 20, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 20, 2025
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
@picnixz
add some new lines
a9b3ca6
cmaloney
cmaloney approved these changes Jan 21, 2025
View reviewed changes
Comment thread Modules/_io/bufferedio.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz added 5 commits January 25, 2025 20:37
@picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/io-111178
9cb97c2
@picnixz
post-merge fix
416d740
@picnixz
use 'ignored' for NOARGS method and 'args' for others
c6f2d0e
@picnixz
use 'dummy' for NOARGS method
ec1e15d
@picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/io-111178
14c0684
@picnixz
picnixz marked this pull request as draft February 7, 2025 11:40
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 7, 2025
@picnixz
picnixz marked this pull request as ready for review February 7, 2025 11:41
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 7, 2025
@picnixz picnixz changed the title gh-111178: fix UBSan failures in Modules/_io gh-111178: fix UBSan failures in Modules/_io/*.c Feb 7, 2025
@picnixz
Merge branch 'main' into fix/ubsan/io-111178
b192d6c
@picnixz
picnixz marked this pull request as draft February 7, 2025 12:10
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 7, 2025
picnixz added 2 commits February 8, 2025 10:43
@picnixz
Do not add an underscore to the macro if none is needed.
bb95ac0
@picnixz
Do Do not use _ + capital letter in cast macros as it is also UB.
2340cae
@picnixz
picnixz marked this pull request as ready for review February 8, 2025 10:40
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 8, 2025
@encukou
encukou merged commit 1988003 into python:main Feb 8, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 8, 2025
@picnixz
picnixz deleted the fix/ubsan/io-111178 branch February 8, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmaloney cmaloney cmaloney approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@picnixz @cmaloney @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.