GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-128588: gh-128550: remove eager tasks optimization that missed and introduced incorrect cancellations (GH-129063) by miss-islington · Pull Request #129089 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 20, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit ed6934e)

Co-authored-by: Thomas Grainger [email protected]
Co-authored-by: Kumar Aditya [email protected]

  • Issue: Cancellation leaks out of asyncio.TaskGroup on 3.12 when using eager tasks #128588

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@graingert @kumaraditya303 @miss-islington
pythongh-128588: pythongh-128550: remove eager tasks optimization tha…
70fb2d0 
…t missed and introduced incorrect cancellations (pythonGH-129063)

(cherry picked from commit ed6934e)

Co-authored-by: Thomas Grainger <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
@miss-islington
miss-islington requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners January 20, 2025 17:13
@bedevere-app bedevere-app Bot mentioned this pull request Jan 20, 2025
Cancellation leaks out of asyncio.TaskGroup on 3.12 when using eager tasks #128588
Closed
@bedevere-app bedevere-app Bot added topic-asyncio type-bug An unexpected behavior, bug, or error labels Jan 20, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 20, 2025
gh-128588: gh-128550: remove eager tasks optimization that missed and introduced incorrect cancellations #129063
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jan 20, 2025
kumaraditya303
kumaraditya303 approved these changes Jan 20, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 20, 2025
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) January 20, 2025 17:15
@kumaraditya303
kumaraditya303 merged commit a1c48a7 into python:3.13 Jan 20, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 20, 2025
@kumaraditya303 kumaraditya303 added the needs backport to 3.12 only security fixes label Jan 20, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 20, 2025

Copy link
Copy Markdown

Thanks @miss-islington for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jan 20, 2025

Copy link
Copy Markdown

Sorry, @miss-islington and @kumaraditya303, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a1c48a750cc52332b0ed16ea8ffa07c18eaee201 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned kumaraditya303 Jan 20, 2025
@hugovk hugovk removed the needs backport to 3.12 only security fixes label Feb 26, 2025
@miss-islington
miss-islington deleted the backport-ed6934e-3.13 branch January 2, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@kumaraditya303 kumaraditya303

Labels

topic-asyncio type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @kumaraditya303 @hugovk @graingert
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.