GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: fix UBSan failures in `Modules/cjkcodecs/multibytecodec.c` by picnixz · Pull Request #129090 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jan 20, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 9 commits January 20, 2025 18:16
@picnixz
Add casts macros
d5a8c23
@picnixz
fix UBSan failures for MultibyteCodecObject
efff446
@picnixz
fix UBSan failures for MultibyteIncrementalEncoderObject
a9fe498
@picnixz
fix UBSan failures for MultibyteIncrementalDecoderObject
9ed213b
@picnixz
fix UBSan failures for MultibyteStreamReaderObject
4bcb9b3
@picnixz
fix UBSan failures for MultibyteStreamWriterObject
0c6d52b
@picnixz
suppress unused return values
85b6e93
@picnixz
fixup
eb6df00
@picnixz
Move cast macros to .c
97cd79b
@picnixz picnixz added the skip news label Jan 20, 2025
@picnixz
picnixz requested a review from corona10 as a code owner January 20, 2025 17:32
@bedevere-app bedevere-app Bot mentioned this pull request Jan 20, 2025
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 20, 2025
@corona10 corona10 self-assigned this Jan 21, 2025
@corona10

corona10 commented Jan 21, 2025

Copy link
Copy Markdown
Member

@picnixz I will take a look at this PR by this weekend.
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 approved these changes Jan 25, 2025
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 25, 2025
@corona10
corona10 merged commit f10b7b2 into python:main Jan 25, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 25, 2025
@picnixz
picnixz deleted the fix/ubsan/cjkcodecs-111178 branch February 2, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@corona10 corona10

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.