GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128563: Move GO_TO_INSTRUCTION and PREDICT to cases generator by Fidget-Spinner · Pull Request #129115 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Jan 21, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: A new tail-calling interpreter for significantly better interpreter performance #128563

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
stonebig reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@Fidget-Spinner
Move GO_TO_INSTRUCTION and PREDICT to cases generator
b191528
@Fidget-Spinner
Fidget-Spinner requested a review from markshannon as a code owner January 21, 2025 03:41
@bedevere-app bedevere-app Bot mentioned this pull request Jan 21, 2025
A new tail-calling interpreter for significantly better interpreter performance #128563
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 21, 2025
@Fidget-Spinner Fidget-Spinner added skip news and removed awaiting core review labels Jan 21, 2025
Fidget-Spinner added 2 commits January 21, 2025 11:49
@Fidget-Spinner
Try fix on macOS
47f973b
@Fidget-Spinner
Update test_generated_cases.py
c2c68de
markshannon
markshannon requested changes Jan 21, 2025
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
A couple of small changes needed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_generated_cases.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/cases_generator/tier1_generator.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Jan 21, 2025

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting changes label Jan 21, 2025
@Fidget-Spinner
Address review
36408f2
@Fidget-Spinner

Fidget-Spinner commented Jan 21, 2025

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels Jan 21, 2025
@bedevere-app

bedevere-app Bot commented Jan 21, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app
bedevere-app Bot requested a review from markshannon January 21, 2025 10:51
@Fidget-Spinner
alignment
76e8b58
markshannon
markshannon approved these changes Jan 21, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting change review labels Jan 21, 2025
@Fidget-Spinner
Fidget-Spinner merged commit 86c1a60 into python:main Jan 22, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 22, 2025
@Fidget-Spinner
Fidget-Spinner deleted the generate_goto branch January 22, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Fidget-Spinner @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.