GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128679: Use _PyThreadState_GET() in tracemalloc.c by vstinner · Pull Request #129126 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jan 21, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Replace uncommon PyGILState_GetThisThreadState() with common _PyThreadState_GET().

  • Issue: Race condition in tracemalloc causes segfaults #128679

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-128679: Use _PyThreadState_GET() in tracemalloc.c
96146dd 
Replace uncommon PyGILState_GetThisThreadState() with common
_PyThreadState_GET().
@vstinner vstinner added the skip news label Jan 21, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 21, 2025
Race condition in tracemalloc causes segfaults #128679
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 21, 2025
kumaraditya303
kumaraditya303 approved these changes Jan 21, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 21, 2025
@vstinner
vstinner merged commit 31f149d into python:main Jan 21, 2025
@vstinner
vstinner deleted the tracemalloc_tstate branch January 21, 2025 13:43
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 21, 2025
@vstinner

vstinner commented Jan 21, 2025

Copy link
Copy Markdown
Member Author

Merged. Thanks for the review @kumaraditya303.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.