GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-129185: Fix crash during interpreter finalization in PyTraceMalloc_Untrack by rostan-t · Pull Request #129188 · python/cpython

Conversation

@rostan-t

@rostan-t rostan-t commented Jan 22, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

This fixes the crash by moving _PyTraceMalloc_Fini() after _PyImport_Fini(). I'm not sure if it breaks some invariant that I'm not aware of or even if it's the best solution, happy to take feedbacks!

  • Issue: Segmentation fault during interpreter finalization in PyTraceMalloc_Untrack #129185

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rostan-t
Finalize imports before tracemalloc
3245947 
Signed-off-by: Rostan Tabet <[email protected]>
@rostan-t
rostan-t requested a review from ericsnowcurrently as a code owner January 22, 2025 16:29
@ghost

ghost commented Jan 22, 2025

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

  • [email protected]

Click the button to sign:
CLA not signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Jan 22, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 22, 2025
Segmentation fault during interpreter finalization in PyTraceMalloc_Untrack #129185
Closed
@bedevere-app

bedevere-app Bot commented Jan 22, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ZeroIntensity
ZeroIntensity reviewed Jan 22, 2025
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner

vstinner commented Jan 22, 2025

Copy link
Copy Markdown
Member

I wrote a different fix with a test: PR gh-129191.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rostan-t

rostan-t commented Jan 22, 2025

Copy link
Copy Markdown
Author

Thanks @vstinner! Closing this one
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rostan-t rostan-t closed this Jan 22, 2025
vstinner
vstinner reviewed Jan 22, 2025
View reviewed changes
Comment thread Python/pylifecycle.c

/* Disable tracemalloc after all Python objects have been destroyed,
so it is possible to use tracemalloc in objects destructor. */
_PyTraceMalloc_Fini();

@vstinner vstinner Jan 22, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this fix is enough. Some objects can be deleted later, in finalize_interp_clear(). So I wrote a different fix to restore the old behavior: PR gh-129191.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rostan-t reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@ZeroIntensity ZeroIntensity ZeroIntensity left review comments
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@rostan-t @vstinner @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.