GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91048: Also clear and set ts->asyncio_running_task with eager tasks by ambv · Pull Request #129197 · python/cpython

Conversation

@ambv

@ambv ambv commented Jan 22, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This was missing from gh-124640. It's already covered by the new test_asyncio/test_free_threading.py in combination with the runtime assertion in set_ts_asyncio_running_task.

  • Issue: Async Call-Stack Reconstruction #91048

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ambv
pythongh-91048: Also clear and set ts->asyncio_running_task with eage…
975cfa7 
…r tasks

This was missing from pythongh-124640. It's already covered by the new
test_asyncio/test_free_threading.py in combination with the runtime
assertion in set_ts_asyncio_running_task.
@ambv
ambv requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners January 22, 2025 20:18
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 22, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 22, 2025
Async Call-Stack Reconstruction #91048
Closed
@ambv ambv added the skip news label Jan 22, 2025
kumaraditya303
kumaraditya303 reviewed Jan 23, 2025
View reviewed changes
Comment thread Modules/_asynciomodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ambv @kumaraditya303
Update _asynciomodule.c
6a9f478 
Co-authored-by: Kumar Aditya <[email protected]>
@encukou encukou added stdlib Standard Library Python modules in the Lib/ directory topic-asyncio labels Jan 23, 2025
kumaraditya303
kumaraditya303 reviewed Jan 23, 2025
View reviewed changes
Comment thread Modules/_asynciomodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Jan 23, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 23, 2025
@ambv @kumaraditya303
Update Modules/_asynciomodule.c
90fec6c 
Co-authored-by: Kumar Aditya <[email protected]>
@ambv
ambv merged commit fc3d400 into python:main Jan 23, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 23, 2025
@ambv
ambv deleted the gh-91048-eager-tasks branch January 23, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news stdlib Standard Library Python modules in the Lib/ directory topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ambv @kumaraditya303 @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.